From: Eli Zaretskii <eliz@gnu.org>
To: Skip Montanaro <skip.montanaro@gmail.com>
Cc: 38511@debbugs.gnu.org
Subject: bug#38511: etags seems to be confused by macros
Date: Sat, 07 Dec 2019 09:14:39 +0200 [thread overview]
Message-ID: <83sglwfvz4.fsf@gnu.org> (raw)
In-Reply-To: <CANc-5Uzsk-24uhHnRCRZjSxph=Ei1zdtLau9jjUDLkwwHjQc_Q@mail.gmail.com> (message from Skip Montanaro on Fri, 6 Dec 2019 14:20:14 -0600)
> From: Skip Montanaro <skip.montanaro@gmail.com>
> Date: Fri, 6 Dec 2019 14:20:14 -0600
>
> I use speedbar in Emacs, which relies on etags to generate tag files.
> The Python source defines a macro named Py_LOCAL_INLINE, which is used
> to select the appropriate spelling of "static inline":
>
> #if defined(_MSC_VER)
> ...
> # define Py_LOCAL_INLINE(type) static __inline type __fastcall
> #else
> ...
> # define Py_LOCAL_INLINE(type) static inline type
> #endif
>
> It's used like so:
>
> Py_LOCAL_INLINE(void)
> stackdepth_push(basicblock ***sp, basicblock *b, int depth)
> {
> assert(b->b_startdepth < 0 || b->b_startdepth == depth);
> if (b->b_startdepth < depth && b->b_startdepth < 100) {
> assert(b->b_startdepth < 0);
> b->b_startdepth = depth;
> *(*sp)++ = b;
> }
> }
>
> It all works well. Etags though, thinks the file contains a function
> named "Py_LOCAL_INLINE" and completely misses the actual function,
> "stackdepth_push".
Etags works by looking at the source at face value, and it doesn't
expand macros as a C compiler would. So this:
Py_LOCAL_INLINE(void) stackdepth_push(basicblock ***sp, basicblock *b, int depth)
looks to its naïve lexical analysis very much like a K&R definition of
a function and declaration of its arguments:
Py_LOCAL_INLINE(foo) int foo(bar)
> Seems like a bug to me, but it's not obvious if there is a trivial
> fix.
Patches are welcome, if someone has an idea for how to fix that.
Thanks.
next prev parent reply other threads:[~2019-12-07 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 20:20 bug#38511: etags seems to be confused by macros Skip Montanaro
2019-12-07 7:14 ` Eli Zaretskii [this message]
2019-12-09 10:59 ` Francesco Potortì
2019-12-09 12:39 ` Skip Montanaro
2019-12-09 13:30 ` Francesco Potortì
2021-08-31 2:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sglwfvz4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38511@debbugs.gnu.org \
--cc=skip.montanaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).