From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation Date: Sat, 21 Dec 2019 11:38:36 +0200 Message-ID: <83sgleyq5f.fsf@gnu.org> References: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="57326"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38675@debbugs.gnu.org To: James Felix Black Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 21 10:39:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iibE6-000En6-HL for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 10:39:10 +0100 Original-Received: from localhost ([::1]:37942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iibE4-00017i-PQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 04:39:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49530) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iibDz-00017O-Gs for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 04:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iibDy-0005Yi-En for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 04:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iibDy-0005Xz-9j for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 04:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iibDy-0001Ad-6Y for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 04:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2019 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38675 X-GNU-PR-Package: emacs Original-Received: via spool by 38675-submit@debbugs.gnu.org id=B38675.15769211374489 (code B ref 38675); Sat, 21 Dec 2019 09:39:02 +0000 Original-Received: (at 38675) by debbugs.gnu.org; 21 Dec 2019 09:38:57 +0000 Original-Received: from localhost ([127.0.0.1]:47614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iibDt-0001AK-K9 for submit@debbugs.gnu.org; Sat, 21 Dec 2019 04:38:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iibDs-0001A9-7N for 38675@debbugs.gnu.org; Sat, 21 Dec 2019 04:38:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iibDk-00053m-KY; Sat, 21 Dec 2019 04:38:51 -0500 Original-Received: from [176.228.60.248] (port=2106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iibDk-0000GS-3g; Sat, 21 Dec 2019 04:38:48 -0500 In-reply-to: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> (message from James Felix Black on Thu, 19 Dec 2019 12:49:01 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173599 Archived-At: > From: James Felix Black > Date: Thu, 19 Dec 2019 12:49:01 -0500 > > This was discovered in `haskell-mode` [1]. The documentation of define-obsolete-face-alias claims that `when` is optional, but the macro definition does not follow the docs. This patch fixes the problem. I'm not sure this isn't a confusion caused by ambiguous wording of the doc string. I think by "if provided" it means that WHEN can be nil. The ELisp manual, btw, doesn't have this problem. Would it be okay to modify the doc string instead to say WHEN is required, but can be nil? Thanks.