From: Eli Zaretskii <eliz@gnu.org>
To: Damien Cassou <damien@cassou.me>
Cc: alex.branham@gmail.com, eggert@cs.ucla.edu, k.stevens@ieee.org,
38583@debbugs.gnu.org, zappo@gnu.org, larsi@gnus.org
Subject: bug#38583: [PATCH] 27.0.50; Add unattended spell-checking to checkdoc
Date: Sat, 11 Jan 2020 14:26:16 +0200 [thread overview]
Message-ID: <83sgkm6uxj.fsf@gnu.org> (raw)
In-Reply-To: <874kx28b7m.fsf@cassou.me> (message from Damien Cassou on Sat, 11 Jan 2020 12:49:17 +0100)
> From: Damien Cassou <damien@cassou.me>
> Cc: bug-gnu-emacs@gnu.org, k.stevens@ieee.org, zappo@gnu.org,
> alex.branham@gmail.com, larsi@gnus.org, eggert@cs.ucla.edu
> Date: Sat, 11 Jan 2020 12:49:17 +0100
>
> Damien Cassou <damien@cassou.me> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >> You mean, this is in addition to the previous patches? If so, I'd
> >> prefer a single patch.
> >
> > you want all the changes merged into a single patch? This seems much
> > harder to review but here it is.
>
> any news?
Sorry, it fell through the cracks.
However, I was about to push it now, but compiling the modified
version generates warnings:
ELC emacs-lisp/checkdoc.elc
In checkdoc-ispell-docstring-engine:
emacs-lisp/checkdoc.el:2161:47:Warning: reference to free variable
`ispell-format-word-function'
emacs-lisp/checkdoc.el:2162:62:Warning: reference to free variable
`ispell-program-name'
emacs-lisp/checkdoc.el:2163:42:Warning: reference to free variable
`ispell-current-dictionary'
In end of data:
emacs-lisp/checkdoc.el:2714:1:Warning: the following functions are not known
to be defined: ispell-set-spellchecker-params,
ispell-accept-buffer-local-defs, ispell-correct-p
Could you please augment the patch so that these warnings are avoided?
Also, please mention the bug number in the commit log message.
TIA
next prev parent reply other threads:[~2020-01-11 12:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 21:26 bug#38583: [PATCH] 27.0.50; Add unattended spell-checking to checkdoc Damien Cassou
2019-12-13 9:05 ` Eli Zaretskii
2019-12-13 19:53 ` Damien Cassou
2019-12-13 19:59 ` Eli Zaretskii
2019-12-27 11:51 ` Damien Cassou
2019-12-27 14:08 ` Eli Zaretskii
2019-12-27 14:43 ` Damien Cassou
2020-01-11 11:49 ` Damien Cassou
2020-01-11 12:26 ` Eli Zaretskii [this message]
2020-01-13 5:19 ` Damien Cassou
2020-01-16 18:43 ` Eli Zaretskii
2020-01-16 21:07 ` Damien Cassou
2020-01-17 7:59 ` Eli Zaretskii
2020-01-17 9:06 ` Damien Cassou
2020-01-17 9:49 ` Eli Zaretskii
2020-01-17 10:35 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgkm6uxj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38583@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=damien@cassou.me \
--cc=eggert@cs.ucla.edu \
--cc=k.stevens@ieee.org \
--cc=larsi@gnus.org \
--cc=zappo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).