From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37189: 25.4.1: vc-hg-ignore implementation is missing Date: Sat, 08 Feb 2020 22:05:18 +0200 Message-ID: <83sgjkdev5.fsf@gnu.org> References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <52917e6f-2f00-25cf-4353-dfb40287d0ea@gmx.de> <83pnkrdpb3.fsf@gnu.org> <679942e8-abe9-b0fc-720d-75a54d8d0b5a@gmx.de> <95da41e8-7a55-a15c-cfa7-d70366f9ee6b@gmx.de> <412195c1-e196-12af-933b-0312f5075847@yandex.ru> <57825d73-27a4-d5f5-8198-a172796a558a@gmx.de> <1ebc6077-9175-65ba-4996-282bb2c8eca5@yandex.ru> <6145d6f6-37a8-7166-731b-57669086b145@gmx.de> <838slmk90j.fsf@gnu.org> <83h806gp2w.fsf@gnu.org> <8336bmg1o9.fsf@gnu.org> <2354821b-5c1e-f9e3-3a64-4ff978ded33b@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="124030"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37189@debbugs.gnu.org, dgutov@yandex.ru To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 08 21:06:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0WMl-000W8h-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 21:06:11 +0100 Original-Received: from localhost ([::1]:44934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0WMk-0004CL-0z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Feb 2020 15:06:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58080) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0WMd-0004C8-C5 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 15:06:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0WMc-0005az-AF for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 15:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0WMc-0005ac-6o for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 15:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0WMc-0005f8-1i for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2020 15:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2020 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.158119234621745 (code B ref 37189); Sat, 08 Feb 2020 20:06:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 8 Feb 2020 20:05:46 +0000 Original-Received: from localhost ([127.0.0.1]:51864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0WML-0005ef-Lj for submit@debbugs.gnu.org; Sat, 08 Feb 2020 15:05:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0WMK-0005eS-0g for 37189@debbugs.gnu.org; Sat, 08 Feb 2020 15:05:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j0WME-0004tD-Ce; Sat, 08 Feb 2020 15:05:38 -0500 Original-Received: from [176.228.60.248] (port=2173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j0WMD-0002ZJ-8P; Sat, 08 Feb 2020 15:05:38 -0500 In-reply-to: <2354821b-5c1e-f9e3-3a64-4ff978ded33b@gmx.de> (message from Wolfgang Scherer on Sat, 8 Feb 2020 20:45:34 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175809 Archived-At: > Cc: 37189@debbugs.gnu.org > From: Wolfgang Scherer > Date: Sat, 8 Feb 2020 20:45:34 +0100 > > The status quo before Emacs 27 is: > > 1. The argument FILE of `vc-ignore` is documented to accept a wildcard specification. This is the use case "pattern". > > 2. `vc-ignore` is called from `vc-dir-ignore` with either an absolute or relative filename. This is the use case "file path". > > 3. Some backends expect a file path, some backends expect a pattern. This cannot be fixed without adding a parameter to `vc-ignore`, `vc--ignore`. > > +-----------------------+-------------+-----------+ > | function              | file path   | pattern   | > +=======================+=============+===========+ > | :func:`vc-ignore`     | strong hint | yes       | > +-----------------------+-------------+-----------+ > | :func:`vc-dir-ignore` | mandatory   | no        | > +-----------------------+-------------+-----------+ > | :func:`vc-cvs-ignore` | no          | mandatory | > +-----------------------+-------------+-----------+ > | :func:`vc-svn-ignore` | mandatory   | no        | > +-----------------------+-------------+-----------+ > | :func:`vc-src-ignore` | --          | --        | > +-----------------------+-------------+-----------+ > | :func:`vc-bzr-ignore` | no          | mandatory | > +-----------------------+-------------+-----------+ > | :func:`vc-git-ignore` | no          | mandatory | > +-----------------------+-------------+-----------+ > | :func:`vc-hg-ignore`  | no          | mandatory | > +-----------------------+-------------+-----------+ > | :func:`vc-mtn-ignore` | --          | --        | > +-----------------------+-------------+-----------+ This shows that (ignoring mtn for now) all of the functions support the "pattern" case, except vc-svn-ignore. However, the doc string of vc-svn-ignore says "Ignore FILE under Subversion. FILE is a wildcard specification, either relative to DIRECTORY or absolute." So it looks like it, too, supports the "pattern" use case, or what am I missing? Now, vc-dir-ignore indeed ignores only one file, but since a file name is a special case of a wildcard, I wonder why you say there's a need in an additional argument. Can you elaborate? > I have already implemented the core handler `vc-default-ignore` replacing the defunct handlers for CVS, Git, Hg, Bzr by parameter sets. The additional parameter set for SRC is also available. I am planning on implementing Mtn. I do not plan on implementing or fixing SVN (or maybe I will). >From my POV, it is much more important to support SVN than to support Monotone. But that's me. > I would really like to close this thread and open one about the correct implementation of `vc-ignore`. Feel free to start a new thread, but I really don't see how that could be of any help. In particular, this thread discusses a specific bug (or several related ones), and the new thread will discuss those same bugs, right? Then it makes little sense to start a new thread about the same bug. Thanks.