From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41125: 28.0.50; Fwindow_text_pixel_size uses FETCH_CHAR (charpos) Date: Fri, 08 May 2020 13:37:42 +0300 Message-ID: <83sggaiufd.fsf@gnu.org> References: <83mu6jkgto.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37750"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41125-done@debbugs.gnu.org, pipcet@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 08 12:39:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jX0PO-0009iG-1s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 12:39:10 +0200 Original-Received: from localhost ([::1]:59186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX0PN-00070T-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 May 2020 06:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX0PG-0006zr-29 for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 06:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jX0PF-0004mZ-Ow for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 06:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jX0PF-0003Wm-Mc for bug-gnu-emacs@gnu.org; Fri, 08 May 2020 06:39:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 May 2020 10:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41125 X-GNU-PR-Package: emacs Mail-Followup-To: 41125@debbugs.gnu.org, eliz@gnu.org, pipcet@gmail.com Original-Received: via spool by 41125-done@debbugs.gnu.org id=D41125.158893428413487 (code D ref 41125); Fri, 08 May 2020 10:39:01 +0000 Original-Received: (at 41125-done) by debbugs.gnu.org; 8 May 2020 10:38:04 +0000 Original-Received: from localhost ([127.0.0.1]:44664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jX0OK-0003VQ-1a for submit@debbugs.gnu.org; Fri, 08 May 2020 06:38:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jX0OH-0003Ub-Uq for 41125-done@debbugs.gnu.org; Fri, 08 May 2020 06:38:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49762) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX0OC-0002Kg-63; Fri, 08 May 2020 06:37:56 -0400 Original-Received: from [176.228.60.248] (port=3124 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jX0OA-0002f4-P7; Fri, 08 May 2020 06:37:55 -0400 In-Reply-To: (message from martin rudalics on Fri, 8 May 2020 09:18:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179919 Archived-At: > Cc: 41125@debbugs.gnu.org > From: martin rudalics > Date: Fri, 8 May 2020 09:18:27 +0200 > > >> which cannot possibly be correct: FETCH_CHAR takes a byte position, > >> not a character position, but BEGV and ZV are measured in characters. > > > > Ouch! Thanks. Does the patch below look good? > > It does. Thanks for fixing yet another of my blunders in this function. > And thanks to Pip for catching it. Thanks, I pushed the fix to the emacs-27 branch.