From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41627: 28.0.50; Emacs with cairo build segfault in HELLO file Date: Mon, 01 Jun 2020 19:35:18 +0300 Message-ID: <83sgfeeoc9.fsf@gnu.org> References: <83a71okvdl.fsf@gnu.org> <0ac5574a-3e61-182c-406a-94500b66cca6@163.com> <83v9kcj9uu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="116361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41627@debbugs.gnu.org, all_but_last@163.com To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 01 18:36:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfnQ0-000UBN-Qt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 18:36:08 +0200 Original-Received: from localhost ([::1]:35772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfnPz-0005mk-G6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 12:36:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfnPt-0005mb-Sj for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:36:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfnPt-0007bT-Jo for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfnPt-0001C9-Hf for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 12:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jun 2020 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41627 X-GNU-PR-Package: emacs Original-Received: via spool by 41627-submit@debbugs.gnu.org id=B41627.15910293244547 (code B ref 41627); Mon, 01 Jun 2020 16:36:01 +0000 Original-Received: (at 41627) by debbugs.gnu.org; 1 Jun 2020 16:35:24 +0000 Original-Received: from localhost ([127.0.0.1]:36853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfnPI-0001BG-AZ for submit@debbugs.gnu.org; Mon, 01 Jun 2020 12:35:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfnPG-0001B0-Os for 41627@debbugs.gnu.org; Mon, 01 Jun 2020 12:35:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52167) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfnP9-0006tn-J8; Mon, 01 Jun 2020 12:35:15 -0400 Original-Received: from [176.228.60.248] (port=4816 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jfnP9-0006Ha-0E; Mon, 01 Jun 2020 12:35:15 -0400 In-Reply-To: (message from Pip Cet on Sun, 31 May 2020 20:45:56 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181350 Archived-At: > From: Pip Cet > Date: Sun, 31 May 2020 20:45:56 +0000 > Cc: Zihao Zhu , 41627@debbugs.gnu.org > > > Can someone please propose a patch along these lines? I cannot easily > > test a Cairo build, so I won't try showing a patch. > > How about this? LGTM, thanks. I gather that you tested this bail-out, and saw that it does TRT (probably skipping the problematic font)? > (I'm not sure how and whether `match' is supposed to be freed in the > success case, or whether it's simply leaked). >From some code fragments I see on the net, I think you are right, and we should free it before returning. Btw, there are more calls to cairo_ft_scaled_font_lock_face in our code followed by unconditional dereference of the result...