From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Date: Wed, 26 Aug 2020 16:07:01 +0300 Message-ID: <83sgc936a2.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ft@bewatermyfriend.org, 18074@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 15:09:54 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAvBZ-000504-9M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 15:09:53 +0200 Original-Received: from localhost ([::1]:34012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAvBY-0000yB-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 09:09:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAv9m-0006JK-9Q for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAv9m-0002Ib-0O for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAv9l-00016A-RW for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 09:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18074 X-GNU-PR-Package: emacs Original-Received: via spool by 18074-submit@debbugs.gnu.org id=B18074.15984472424176 (code B ref 18074); Wed, 26 Aug 2020 13:08:01 +0000 Original-Received: (at 18074) by debbugs.gnu.org; 26 Aug 2020 13:07:22 +0000 Original-Received: from localhost ([127.0.0.1]:37777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAv98-00015I-9g for submit@debbugs.gnu.org; Wed, 26 Aug 2020 09:07:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAv97-000155-4q for 18074@debbugs.gnu.org; Wed, 26 Aug 2020 09:07:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59549) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAv91-0002Fn-LF; Wed, 26 Aug 2020 09:07:15 -0400 Original-Received: from [176.228.60.248] (port=2598 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kAv90-0007NC-TM; Wed, 26 Aug 2020 09:07:15 -0400 In-Reply-To: (message from Mauro Aranda on Wed, 26 Aug 2020 09:50:34 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186437 Archived-At: > From: Mauro Aranda > Date: Wed, 26 Aug 2020 09:50:34 -0300 > Cc: 18074@debbugs.gnu.org, Eli Zaretskii > > > (deftheme foobar "Foobar theme") > > (custom-theme-set-faces 'foobar > > '(default ((default :slant normal > > :weight bold > > :foreground "white" > > :background "black") > > (t :foreground "blue")))) > > > > What I would expect is the `blue' foreground definition from the `t' > > clause to override the `white' foreground definition from the `default' > > clause. But alas, it doesn't work, the foreground remains white. > > I can reproduce this in Emacs 27, but not with current master. > > It looks like this was fixed in: > commit 05d365d3105371ec956f31f109a2de14c5cf67df > Author: Eli Zaretskii > Date: Sat Apr 4 09:59:16 2020 +0300 > > Fix face spec handling for 'default' "terminal class" > > * lisp/faces.el (face-spec-choose): Reverse order of 'defaults' > and 'result' when generating attribute list, so that the spec for > 'default' "terminal class" is indeed overridden by the actual > class's spec, per the documentation. (Bug#40336) > > CCing Eli, hoping he can confirm. Confirmed, thanks.