From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: ft@bewatermyfriend.org, 18074@debbugs.gnu.org
Subject: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised
Date: Wed, 26 Aug 2020 16:07:01 +0300 [thread overview]
Message-ID: <83sgc936a2.fsf@gnu.org> (raw)
In-Reply-To: <CABczVwcst1YJ+pRs8xdRXdXuYVB-7YeUp36kvGm2r-PXPoVN+w@mail.gmail.com> (message from Mauro Aranda on Wed, 26 Aug 2020 09:50:34 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Wed, 26 Aug 2020 09:50:34 -0300
> Cc: 18074@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>
> > (deftheme foobar "Foobar theme")
> > (custom-theme-set-faces 'foobar
> > '(default ((default :slant normal
> > :weight bold
> > :foreground "white"
> > :background "black")
> > (t :foreground "blue"))))
> >
> > What I would expect is the `blue' foreground definition from the `t'
> > clause to override the `white' foreground definition from the `default'
> > clause. But alas, it doesn't work, the foreground remains white.
>
> I can reproduce this in Emacs 27, but not with current master.
>
> It looks like this was fixed in:
> commit 05d365d3105371ec956f31f109a2de14c5cf67df
> Author: Eli Zaretskii <eliz@gnu.org>
> Date: Sat Apr 4 09:59:16 2020 +0300
>
> Fix face spec handling for 'default' "terminal class"
>
> * lisp/faces.el (face-spec-choose): Reverse order of 'defaults'
> and 'result' when generating attribute list, so that the spec for
> 'default' "terminal class" is indeed overridden by the actual
> class's spec, per the documentation. (Bug#40336)
>
> CCing Eli, hoping he can confirm.
Confirmed, thanks.
next prev parent reply other threads:[~2020-08-26 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 21:53 bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Frank Terbeck
2014-07-22 23:48 ` bug#18074: Reproduced with current HEAD of `emacs-24' branch Frank Terbeck
2020-08-26 12:50 ` bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Mauro Aranda
2020-08-26 13:07 ` Eli Zaretskii [this message]
2020-08-26 13:51 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgc936a2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18074@debbugs.gnu.org \
--cc=ft@bewatermyfriend.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).