From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Date: Fri, 28 Aug 2020 10:01:43 +0300 Message-ID: <83sgc7z220.fsf@gnu.org> References: <693aa189-03fa-b963-89eb-ce19c51ba325@cs.ucla.edu> <83wo1jz32t.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36523"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, yegortimoshenko@gmail.com To: eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 09:03:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBYPk-0009LY-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 09:03:08 +0200 Original-Received: from localhost ([::1]:39134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBYPj-0005x1-AV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 03:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBYPe-0005wt-0u for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 03:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBYPd-0004Io-Na for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 03:03:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBYPd-00025m-Jj for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 03:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26911-submit@debbugs.gnu.org id=B26911.15985981257978 (code B ref 26911); Fri, 28 Aug 2020 07:03:01 +0000 Original-Received: (at 26911) by debbugs.gnu.org; 28 Aug 2020 07:02:05 +0000 Original-Received: from localhost ([127.0.0.1]:44951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBYOj-00024c-Gd for submit@debbugs.gnu.org; Fri, 28 Aug 2020 03:02:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBYOg-000246-BD for 26911@debbugs.gnu.org; Fri, 28 Aug 2020 03:02:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41004) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBYOY-0004FK-VT; Fri, 28 Aug 2020 03:01:54 -0400 Original-Received: from [176.228.60.248] (port=1766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBYOX-0007mi-L3; Fri, 28 Aug 2020 03:01:54 -0400 In-Reply-To: <83wo1jz32t.fsf@gnu.org> (message from Eli Zaretskii on Fri, 28 Aug 2020 09:39:38 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186583 Archived-At: > Date: Fri, 28 Aug 2020 09:39:38 +0300 > From: Eli Zaretskii > Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, > yegortimoshenko@gmail.com > > > Cc: Michael Albinus , 26911@debbugs.gnu.org, > > Eli Zaretskii , Yegor Timoshenko > > From: Paul Eggert > > Date: Thu, 27 Aug 2020 14:53:52 -0700 > > > > Thanks for reporting that. Sigh, too often when I fix one bug in > > expand-file-name I introduce another. I installed the attached patch to fix this > > bug (I and I hope it doesn't introduce yet another :-). > > Two tests (including the new one) fail here on MS-Windows: I've now fixed most of the failures, but one still remains, and it definitely seems to be due to the latest changes in expand-file-name, note the "c:." part below: Test fileio-tests--expand-file-name-trailing-slash backtrace: signal(ert-test-failed (((should (equal (expand-file-name (concat "c ert-fail(((should (equal (expand-file-name (concat "c:/" fooslashali (if (unwind-protect (setq value-207 (apply fn-205 args-206)) (setq f (let (form-description-209) (if (unwind-protect (setq value-207 (app (let ((value-207 'ert-form-evaluation-aborted-208)) (let (form-descr (let* ((fn-205 #'equal) (args-206 (condition-case err (let ((signal- (progn (let* ((fn-200 #'equal) (args-201 (condition-case err (let (( (if (memq system-type '(windows-nt ms-dos)) (progn (let* ((fn-200 #' (let ((fooslashalias (car --dolist-tail--))) (if (memq system-type ' (while --dolist-tail-- (let ((fooslashalias (car --dolist-tail--))) (let ((--dolist-tail-- '("foo/" "foo//" "foo/." "foo//." "foo///././ (closure (t) nil (let ((--dolist-tail-- '("foo/" "foo//" "foo/." "fo ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name fileio-tests--expand-file-name-traili ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ";." "-l" "ert" "-l" "src/fileio-tests.el" "--e command-line() normal-top-level() Test fileio-tests--expand-file-name-trailing-slash condition: (ert-test-failed ((should (equal (expand-file-name ...) "c:/foo/")) :form (equal "c:./foo/" "c:/foo/") :value nil :explanation (arrays-of-different-length 8 7 "c:./foo/" "c:/foo/" first-mismatch-at 2))) FAILED 5/12 fileio-tests--expand-file-name-trailing-slash (0.000000 sec)