From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43439: [PATCH] doprnt improvements Date: Thu, 15 Oct 2020 22:05:16 +0300 Message-ID: <83sgafwbrn.fsf@gnu.org> References: <20200916015051.20517-1-eggert@cs.ucla.edu> <83o8m57oq7.fsf@gnu.org> <31fb34a7-26c3-552d-e8d4-74624455ffcb@cs.ucla.edu> <838sd75yor.fsf@gnu.org> <83y2k7we8a.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43439@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 15 21:06:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT8Zo-0001Km-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 21:06:12 +0200 Original-Received: from localhost ([::1]:40324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT8Zn-0002Er-NW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 15:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT8Ze-0002Ee-56 for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 15:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT8Zd-0001nm-MZ for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 15:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kT8Zd-0006P1-IW for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 15:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43439-submit@debbugs.gnu.org id=B43439.160278872924569 (code B ref 43439); Thu, 15 Oct 2020 19:06:01 +0000 Original-Received: (at 43439) by debbugs.gnu.org; 15 Oct 2020 19:05:29 +0000 Original-Received: from localhost ([127.0.0.1]:56597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT8Z6-0006OD-NW for submit@debbugs.gnu.org; Thu, 15 Oct 2020 15:05:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT8Z5-0006Nx-4P for 43439@debbugs.gnu.org; Thu, 15 Oct 2020 15:05:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56703) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT8Yy-0001eL-Nk; Thu, 15 Oct 2020 15:05:20 -0400 Original-Received: from [176.228.60.248] (port=1387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kT8Yx-0003Ic-S2; Thu, 15 Oct 2020 15:05:20 -0400 In-Reply-To: (message from Paul Eggert on Thu, 15 Oct 2020 11:50:48 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190627 Archived-At: > Cc: 43439@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 15 Oct 2020 11:50:48 -0700 > > On 10/15/20 11:12 AM, Eli Zaretskii wrote: > > I didn't agree to modifying doprnt in > > significant ways, so you are now suggesting to do an even more radical > > modification, just under another name? > > If you'd rather have the patch keep doprnt entirely as-is (i.e., not change > doprnt's implementation at all), I can easily modify the patch to do that. No, I want to continue calling doprnt directly, not replace all its calls with a call to another function. doprnt by itself is useless unless it is used by the relevant primitives. I see no need to replace it with another function, because doprnt works and works well. > All current Emacs code that calls doprnt would benefit from switching to the > proposed evsnprintf function, an API that is simpler and faster and that has > better static checking with GCC. Yes, that's exactly where we disagree. I made my proposal to find some kind of middle ground, and was disappointed to see you suggesting to move even farther from a potential agreement. In general, I'm against messing with code that has been stable for ages, for ephemeral benefits or minor stylistic reasons. If nothing else, it gets in the way of maintaining Emacs because code I've known for years and could find with my eyes closed constantly shifts and changes under my feet. Another example of this is that src/lisp.h macros look nowadays completely different from what they were several years ago. This need to constantly unlearn that which was burned into my muscle memory is not pleasant at all. Changes that take us forward because they are needed for new and improved features are welcome and justified, but there are no new features in all those changes, including in the doprnt patch. I wish this fever would stop.