From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13780: 24.2; Making find-file-hook customizable seems to cause troublle Date: Wed, 28 Oct 2020 17:15:02 +0200 Message-ID: <83sg9ycrgp.fsf@gnu.org> References: <87k3q1gpba.fsf@sc3d.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27720"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 13780@debbugs.gnu.org, monnier@iro.umontreal.ca, rrt@sc3d.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 28 16:25:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXnKR-000765-Ug for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 16:25:35 +0100 Original-Received: from localhost ([::1]:53096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXnKQ-0000zs-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 11:25:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXnBC-0008FW-6A for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 11:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXnBB-00067m-QR for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 11:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXnBB-0002Oi-Lq for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 11:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2020 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13780-submit@debbugs.gnu.org id=B13780.16038981149152 (code B ref 13780); Wed, 28 Oct 2020 15:16:01 +0000 Original-Received: (at 13780) by debbugs.gnu.org; 28 Oct 2020 15:15:14 +0000 Original-Received: from localhost ([127.0.0.1]:50142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnAP-0002NY-MX for submit@debbugs.gnu.org; Wed, 28 Oct 2020 11:15:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnAN-0002NI-N5 for 13780@debbugs.gnu.org; Wed, 28 Oct 2020 11:15:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46070) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXnAH-0005o7-Qe; Wed, 28 Oct 2020 11:15:05 -0400 Original-Received: from [176.228.60.248] (port=2723 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXnAG-0003MT-AT; Wed, 28 Oct 2020 11:15:05 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 28 Oct 2020 01:52:42 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191885 Archived-At: > From: Stefan Kangas > Date: Wed, 28 Oct 2020 01:52:42 -0700 > Cc: 13780@debbugs.gnu.org, Reuben Thomas > > Stefan Monnier writes: > > >>> So until Custom ...blabla... I think it's better to use defcustom for > >>> hooks very sparingly, i.e. only for those hook we can reasonably > >>> expect will only be modified by the user's customization. > >> So do you think the existing customization ability for find-file-hook > >> should be removed? Or at least some kind of warning attached? > > > > Yes, > > So how about the attached? That's a backward-incompatible change, isn't it? Now a user who types "M-x set-variable RET" will not be able to set this variable, it can only be set via "M-:". Do we have a serious enough reason for that?