From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sat, 31 Oct 2020 10:35:17 +0200 Message-ID: <83sg9uhjy2.fsf@gnu.org> References: <83a6wip43q.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44070@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 31 09:36:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYmN9-0003kQ-0q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 09:36:27 +0100 Original-Received: from localhost ([::1]:38746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYmN8-0006Pp-3Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 04:36:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYmMk-0006Ny-NR for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 04:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYmMk-0008VS-EK for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 04:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYmMk-0003xO-C3 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 04:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.160413334215182 (code B ref 44070); Sat, 31 Oct 2020 08:36:02 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 31 Oct 2020 08:35:42 +0000 Original-Received: from localhost ([127.0.0.1]:60510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYmMP-0003wo-Pg for submit@debbugs.gnu.org; Sat, 31 Oct 2020 04:35:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYmMO-0003wb-NW for 44070@debbugs.gnu.org; Sat, 31 Oct 2020 04:35:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35571) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYmMI-0008GZ-Ux; Sat, 31 Oct 2020 04:35:34 -0400 Original-Received: from [176.228.60.248] (port=2413 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYmMG-0007jN-GJ; Sat, 31 Oct 2020 04:35:33 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 29 Oct 2020 13:54:01 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192253 Archived-At: > From: Stefan Monnier > Cc: 44070@debbugs.gnu.org > Date: Thu, 29 Oct 2020 13:54:01 -0400 > > > If we want the minibuffer behave as if scroll-conservatively was set, > > why not simply set scroll-conservatively in each minibuffer? > > That was my initial thought as well, but when I tried to implement it, > it quickly turned into a scavenge hunt trying to find all the places > where it needs to be set (and re-set after a kill-all-local-variables). That's strange: don't we have a single place where we create the minibuffer? > How 'bout the patch below, then? LGTM, modulo the NEWS and ELisp manual updates. > + DEFVAR_BOOL ("minibuffer-scroll-conservatively", > + minibuffer_scroll_conservatively, > + doc: /* Non-nil means scroll conservatively in minibuffer windows. > +When the value is nil, scrolling in minibuffer windows obeys the > +settings of `scroll-conservatively'. */); I'd say "behaves as if scroll-conservatively were set" instead of "obeys the setting of scroll-conservatively", because the latter can be interpreted as meaning one actually needs to set scroll-conservatively. > + minibuffer_scroll_conservatively = true; /* bug#44070 */ It is IMO generally not useful to have such comments, since the Git history will tell us that much (and then some), provided you don't forget to mention the bug number in the log message. Thanks.