From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sun, 01 Nov 2020 21:36:44 +0200 Message-ID: <83sg9seunn.fsf@gnu.org> References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> <835z6qgrwt.fsf@gnu.org> <83mu01f5o8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44070@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 20:38:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZJBE-0001nK-5D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 20:38:20 +0100 Original-Received: from localhost ([::1]:37588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZJBD-0006T8-3z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 14:38:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZJAw-0006Sk-Pu for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZJAw-0003TC-3X for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZJAw-0001r6-1W for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.16042594247054 (code B ref 44070); Sun, 01 Nov 2020 19:38:02 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 1 Nov 2020 19:37:04 +0000 Original-Received: from localhost ([127.0.0.1]:38581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJA0-0001ph-2H for submit@debbugs.gnu.org; Sun, 01 Nov 2020 14:37:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJ9y-0001pD-A1 for 44070@debbugs.gnu.org; Sun, 01 Nov 2020 14:37:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59744) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZJ9s-0003Pi-Kd; Sun, 01 Nov 2020 14:36:56 -0500 Original-Received: from [176.228.60.248] (port=3027 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZJ9s-0001uw-2D; Sun, 01 Nov 2020 14:36:56 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 01 Nov 2020 13:59:35 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192448 Archived-At: > From: Stefan Monnier > Cc: 44070@debbugs.gnu.org > Date: Sun, 01 Nov 2020 13:59:35 -0500 > > >> Also, I'm not sure that's what we want to do: as I argued in my previous > >> message, this change is mostly meant to better fit the behavior of > >> resize_mini_window, and that behavior applies to all mini-windows, > >> regardless if they're used for a minibuffer or something else. > > My line of thinking was that, while in minibuffers we usually want to > > see the end of the text, that is not necessarily true in echo-area > > messages. > > Yet, that's what `resize_mini_window` does for all mini-windows > regardless of it's an echo-area or not. Resizing is one thing; which part of partially displayed text to show is another. They aren't the same decisions. > Also, my patch shouldn't affect whether we "see the end of the text", so > maybe I just don't understand what you're referring to. Where do you think point is in an echo-area buffer? > >> I suggest we keep the code as is for now, and we'll consider what to do > >> *if* someone encounters a regression (which, for all we know, could > >> also affect the minibuffer case). > > Then let's leave a FIXME comment about this in those two places where > > you use MINI_WINDOW_P, okay? > > I thought the test of `scroll_minibuffer_conservative` played this role. That's exactly why we need a FIXME: the variable says "minibuffer", but the code checks for mini-window. Anyway, I can add the comment myself; no need to argue.