From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45536: [PATCH] Pretty-print keys without <> around modifiers Date: Tue, 29 Dec 2020 22:01:41 +0200 Message-ID: <83sg7oidp6.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45536@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 21:02:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuLCF-0003PS-DY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 21:02:19 +0100 Original-Received: from localhost ([::1]:45896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuLCE-0007Ka-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 15:02:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuLC0-0007KB-0x for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 15:02:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuLBy-0002qW-RH for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 15:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuLBx-00014Z-P7 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 15:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45536 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45536-submit@debbugs.gnu.org id=B45536.16092721194114 (code B ref 45536); Tue, 29 Dec 2020 20:02:01 +0000 Original-Received: (at 45536) by debbugs.gnu.org; 29 Dec 2020 20:01:59 +0000 Original-Received: from localhost ([127.0.0.1]:40260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuLBu-00014I-PI for submit@debbugs.gnu.org; Tue, 29 Dec 2020 15:01:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuLBr-000141-77 for 45536@debbugs.gnu.org; Tue, 29 Dec 2020 15:01:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37959) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuLBl-0002le-IL; Tue, 29 Dec 2020 15:01:49 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1793 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuLBj-0000ir-KC; Tue, 29 Dec 2020 15:01:48 -0500 In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 29 Dec 2020 17:21:03 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196969 Archived-At: > From: Mattias Engdegård > Date: Tue, 29 Dec 2020 17:21:03 +0100 > > It is a bit inconsistent that keys are described as C-x and but . It would be more logical to write C-. The key parser will happily accept either, but descriptions without modifiers in <> brackets are more legible, and the result is easier to understand and explain. > > Attached is a patch which adapts the code that pretty-prints keys. This is a change for human consumption only; it seems unlikely to affect compatibility. With the patch, is now printed as C-M-. IMO, making this kind of changes is just asking for trouble: the gains are null and void (I don't see why we should care about consistency here), while the potential for breaking something out there is very real.