From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Fri, 06 Aug 2021 09:26:17 +0300 Message-ID: <83sfznhywm.fsf@gnu.org> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> <8735rn8jz6.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21859"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 06 08:27:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBtK2-0005Pe-QA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 08:27:10 +0200 Original-Received: from localhost ([::1]:55096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBtK0-0003w2-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 02:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBtJu-0003tu-R6 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 02:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBtJu-0001Wc-Je for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 02:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBtJu-0004fA-Cw for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 02:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2021 06:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.162823118617882 (code B ref 41343); Fri, 06 Aug 2021 06:27:02 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 6 Aug 2021 06:26:26 +0000 Original-Received: from localhost ([127.0.0.1]:48940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBtJJ-0004eM-P0 for submit@debbugs.gnu.org; Fri, 06 Aug 2021 02:26:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBtJI-0004e9-2X for 41343@debbugs.gnu.org; Fri, 06 Aug 2021 02:26:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37988) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBtJC-0000pE-Cd; Fri, 06 Aug 2021 02:26:18 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3008 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBtJB-000365-Tn; Fri, 06 Aug 2021 02:26:18 -0400 In-Reply-To: <8735rn8jz6.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 06 Aug 2021 03:41:17 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211296 Archived-At: > From: Juri Linkov > Cc: stefankangas@gmail.com, 41343@debbugs.gnu.org > Date: Fri, 06 Aug 2021 03:41:17 +0300 > > >> (defvar tab-line-tab-map > >> (let ((map (make-sparse-keymap))) > >> (define-key map [tab-line mouse-1] 'tab-line-select-tab) > >> (define-key map [tab-line mouse-2] 'tab-line-close-tab) > >> > >> But it's impossible to do the same for the menu-bar and the tool-bar > >> and so in the tab-bar too. > > > > Why not? What prevents that? > > It's too late to change how keys are implemented for tab-bar. > The tab-bar keymap contains such keys as 'tab-1' and 'C-tab-2', > and clicking mouse-1 on tabs emits such events. It doesn't emit > 'mouse-1' and 'mouse-2'. How do we translate mouse clicks into the likes of C-tab-2? And what prevents us from emitting something like tab-close-2 when mouse-2 is clicked? > >> Or do you mean adding an integer variable that holds > >> a number of the mouse button used to close the tab? > >> For example, tab-bar-close-tab-mouse-button = 2. > > > > I think we should explore such possibilities only after we understand > > why normal key bindings don't work. > > It should be possible to implement normal key bindings mouse-1/mouse-2, > but such change will not be backward-compatible. In what way will it be incompatible?