From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click
Date: Fri, 06 Aug 2021 09:26:17 +0300 [thread overview]
Message-ID: <83sfznhywm.fsf@gnu.org> (raw)
In-Reply-To: <8735rn8jz6.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 06 Aug 2021 03:41:17 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: stefankangas@gmail.com, 41343@debbugs.gnu.org
> Date: Fri, 06 Aug 2021 03:41:17 +0300
>
> >> (defvar tab-line-tab-map
> >> (let ((map (make-sparse-keymap)))
> >> (define-key map [tab-line mouse-1] 'tab-line-select-tab)
> >> (define-key map [tab-line mouse-2] 'tab-line-close-tab)
> >>
> >> But it's impossible to do the same for the menu-bar and the tool-bar
> >> and so in the tab-bar too.
> >
> > Why not? What prevents that?
>
> It's too late to change how keys are implemented for tab-bar.
> The tab-bar keymap contains such keys as 'tab-1' and 'C-tab-2',
> and clicking mouse-1 on tabs emits such events. It doesn't emit
> 'mouse-1' and 'mouse-2'.
How do we translate mouse clicks into the likes of C-tab-2? And what
prevents us from emitting something like tab-close-2 when mouse-2 is
clicked?
> >> Or do you mean adding an integer variable that holds
> >> a number of the mouse button used to close the tab?
> >> For example, tab-bar-close-tab-mouse-button = 2.
> >
> > I think we should explore such possibilities only after we understand
> > why normal key bindings don't work.
>
> It should be possible to implement normal key bindings mouse-1/mouse-2,
> but such change will not be backward-compatible.
In what way will it be incompatible?
next prev parent reply other threads:[~2021-08-06 6:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 4:05 bug#41343: tab-bar-mode: Close tab on mouse-2 click Stefan Kangas
2020-05-17 22:12 ` Juri Linkov
2020-05-17 22:23 ` Stefan Kangas
2020-05-18 2:32 ` Eli Zaretskii
2020-05-19 21:54 ` Juri Linkov
2020-05-20 15:59 ` Eli Zaretskii
2021-08-03 22:33 ` Juri Linkov
2021-08-04 11:32 ` Eli Zaretskii
2021-08-04 20:13 ` Juri Linkov
2021-08-05 5:43 ` Eli Zaretskii
2021-08-06 0:41 ` Juri Linkov
2021-08-06 6:26 ` Eli Zaretskii [this message]
2021-08-06 8:20 ` Juri Linkov
2021-08-06 12:38 ` Eli Zaretskii
2021-08-09 7:03 ` Juri Linkov
2021-08-10 12:38 ` Eli Zaretskii
2021-08-11 7:01 ` Juri Linkov
2021-08-11 11:56 ` Eli Zaretskii
2021-08-12 8:09 ` Juri Linkov
2021-08-12 8:43 ` Eli Zaretskii
2021-08-13 7:24 ` Juri Linkov
2021-08-18 18:11 ` Juri Linkov
2021-08-24 14:37 ` Stefan Kangas
2021-09-05 17:18 ` Juri Linkov
2021-09-06 19:40 ` Stefan Kangas
2021-09-08 19:28 ` Juri Linkov
2021-09-08 21:18 ` Stefan Kangas
2021-09-14 6:43 ` Juri Linkov
2021-09-05 17:17 ` Juri Linkov
2021-08-06 16:21 ` bug#41343: [External] : " Drew Adams
2021-08-09 7:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfznhywm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41343@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).