From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse Date: Sun, 10 Oct 2021 20:58:33 +0300 Message-ID: <83sfx8rcc6.fsf@gnu.org> References: <8735ptxhzs.fsf.ref@yahoo.com> <83wnn5qe48.fsf@gnu.org> <87k0j5m5ik.fsf@gnus.org> <83tui9qd2j.fsf@gnu.org> <87fsttm512.fsf@gnus.org> <87y27kbi6y.fsf@mail.linkov.net> <83a6k0phik.fsf@gnu.org> <878rzi11xq.fsf@mail.linkov.net> <83lf3hlv5o.fsf@gnu.org> <87czoso8cz.fsf@mail.linkov.net> <834k9zd9i3.fsf@gnu.org> <87ee93fbw8.fsf@mail.linkov.net> <83pmsm8h1o.fsf@gnu.org> <87a6jq9kdv.fsf@mail.linkov.net> <835yue81lz.fsf@gnu.org> <87bl4657j3.fsf@mail.linkov.net> <83wnmu6l9v.fsf@gnu.org> <87y2787kne.fsf@mail.linkov.net> <83a6jo65kp.fsf@gnu.org> <8735pevc3o.fsf@mail.linkov.net> <838rz516su.fsf@gnu.org> <87zgrhasdm.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1610"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, 50798@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 10 19:59:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZd6W-0000D0-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Oct 2021 19:59:20 +0200 Original-Received: from localhost ([::1]:56792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZd6V-0003NM-1Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Oct 2021 13:59:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZd6E-0003ND-Kl for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 13:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZd6E-000320-Cd for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZd6E-0004hB-8G for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Oct 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50798 X-GNU-PR-Package: emacs Original-Received: via spool by 50798-submit@debbugs.gnu.org id=B50798.163388873418031 (code B ref 50798); Sun, 10 Oct 2021 17:59:02 +0000 Original-Received: (at 50798) by debbugs.gnu.org; 10 Oct 2021 17:58:54 +0000 Original-Received: from localhost ([127.0.0.1]:55828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZd65-0004gk-M0 for submit@debbugs.gnu.org; Sun, 10 Oct 2021 13:58:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZd63-0004gY-Pr for 50798@debbugs.gnu.org; Sun, 10 Oct 2021 13:58:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57750) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZd5x-0002x4-MO; Sun, 10 Oct 2021 13:58:45 -0400 Original-Received: from [87.69.77.57] (port=2925 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZd5x-000230-9S; Sun, 10 Oct 2021 13:58:45 -0400 In-Reply-To: <87zgrhasdm.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 10 Oct 2021 20:04:05 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216826 Archived-At: > From: Juri Linkov > Cc: larsi@gnus.org, luangruo@yahoo.com, 50798@debbugs.gnu.org > Date: Sun, 10 Oct 2021 20:04:05 +0300 > > >> (defface test > >> '((t :height 2.0)) > >> "") > >> > >> (defface test-tab > >> '((default :inherit test) > >> (t :box (:line-width 1 :style released-button))) > >> "") > >> > >> (defface test-highlight > >> '((default :inherit test-tab)) > >> "") > > > > Thanks, but I'm not sure I understand what you expected and why. the > > face 'test' is defined to be twice the width of the default face. The > > face test-highlight inherits from it, but the 't' case doesn't change > > the :height attribute, so it ends up having the same height, just with > > the :box attribute. That's why it looks bad on the header line: its > > height is greater than that of header-line. > > > > What did you expect to happen with these definitions of faces? > > My previous patch avoided inheriting from the face that changes the > height of the mouse-highlight face. Maybe it was the right solution? Did you intend that the face which inherited will NOT have the changed size like the one it inherited from? If so, not inheriting is probably the easiest solution.