unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thibault Polge <thibault@thb.lt>
Cc: 52018@debbugs.gnu.org
Subject: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions
Date: Sun, 21 Nov 2021 17:13:35 +0200	[thread overview]
Message-ID: <83sfvpr17k.fsf@gnu.org> (raw)
In-Reply-To: <871r39hjj3.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 11:48:00 +0100)

> From: Thibault Polge <thibault@thb.lt>
> Date: Sun, 21 Nov 2021 11:48:00 +0100
> 
>  (defvar compilation-finish-functions nil
>    "Functions to call when a compilation process finishes.
>  Each function is called with two arguments: the compilation buffer,
> -and a string describing how the process finished.")
> +and a string describing how the process finished.
> +
> +That string is the sentinel's event type string, see info
> +node `(elisp) Sentinels' for more details.")


But this is not entirely accurate, is it?  The code actually does

           (let ((out-string (format ":%s [%s]" process-status (cdr status)))
                 (msg (format "%s %s" mode-name
                              (replace-regexp-in-string "\n?$" ""
                                                        (car status)))))
    [...]
    (run-hook-with-args 'compilation-finish-functions cur-buffer msg)))

So 'msg' is not just the process status , AFAIU.

Thanks.





  reply	other threads:[~2021-11-21 15:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 10:48 bug#52018: 28.0.60; Improve documentation for compilation-finish-functions Thibault Polge
2021-11-21 15:13 ` Eli Zaretskii [this message]
2021-11-21 19:08   ` Thibault Polge
2021-11-21 19:25     ` Eli Zaretskii
2021-11-21 19:44       ` Thibault Polge
2021-11-21 19:53         ` Eli Zaretskii
2021-11-21 20:00           ` Thibault Polge
2021-11-21 20:11             ` Eli Zaretskii
2021-11-21 20:20               ` Thibault Polge
2021-11-21 20:29                 ` Eli Zaretskii
2021-11-22  9:12                   ` Thibault Polge
2021-11-22 16:56                     ` Eli Zaretskii
2021-11-23  9:26                       ` Thibault Polge
2021-11-23 12:47                         ` Eli Zaretskii
2021-11-24  7:02                           ` Lars Ingebrigtsen
2021-11-24 12:40                             ` Eli Zaretskii
2021-11-24 16:31                               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfvpr17k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52018@debbugs.gnu.org \
    --cc=thibault@thb.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).