From: Eli Zaretskii <eliz@gnu.org>
To: Matt Armstrong <matt@rfc20.org>
Cc: 52202@debbugs.gnu.org
Subject: bug#52202: 29.0.50; try-completion, all-completions support for a list of strings COLLECTION is not documented in their docstrings
Date: Wed, 01 Dec 2021 05:36:45 +0200 [thread overview]
Message-ID: <83sfvdro6q.fsf@gnu.org> (raw)
In-Reply-To: <87wnkpidim.fsf_-_@rfc20.org> (message from Matt Armstrong on Tue, 30 Nov 2021 12:39:45 -0800)
> From: Matt Armstrong <matt@rfc20.org>
> Cc: 52202@debbugs.gnu.org
> Date: Tue, 30 Nov 2021 12:39:45 -0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Matt Armstrong <matt@rfc20.org>
> >> Date: Tue, 30 Nov 2021 11:18:05 -0800
> >>
> >> Attached is a docstring patch against the emacs-28 branch for this
> >> issue.
> >
> > Thanks, but ... all these changes just to say that a list of strings
> > can also be a COLLECTION? This looks like a complete rewrite, and
> > comparing it with the existing doc string is a lot of work. Is the
> > current doc string really that awful and requires such a complete
> > rewrite? Why can't we get away with a smaller, simpler change (that
> > would be easier to review and approve)?
>
> Thanks Eli, I can sympathize with respect to the review difficulty, but
> I couldn't find a simple edit that did a good job. It is more than just
> "list of strings", but I did not realize when I filed the bug. This
> became clear only after I started reading code and trying to document
> the current behavior.
Can you list the aspects which the current doc string doesn't
describe, or describes inaccurately or incorrectly?
Thanks.
next prev parent reply other threads:[~2021-12-01 3:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:59 bug#52202: 29.0.50; try-completion, all-completions support for a list of strings COLLECTION is not documented in their docstrings Matt Armstrong
2021-11-30 19:18 ` bug#52202: [PATCH] " Matt Armstrong
2021-11-30 19:30 ` Eli Zaretskii
2021-11-30 20:39 ` bug#52202: 29.0.50; " Matt Armstrong
2021-12-01 3:36 ` Eli Zaretskii [this message]
2021-12-01 19:43 ` Matt Armstrong
2021-12-01 3:57 ` Lars Ingebrigtsen
2021-12-01 19:49 ` Matt Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfvdro6q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=52202@debbugs.gnu.org \
--cc=matt@rfc20.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).