From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51550: 29.0.50; Customize Group INS buttons sometimes don't have a left box line Date: Mon, 27 Dec 2021 16:55:49 +0200 Message-ID: <83sfuem70q.fsf@gnu.org> References: <87ee80gezy.fsf.ref@yahoo.com> <87ee80gezy.fsf@yahoo.com> <83a6iolzjd.fsf@gnu.org> <87zgqnk74n.fsf@rub.de> <83ee7zll84.fsf@gnu.org> <87wnlrfhdk.fsf@yahoo.com> <831r3ylk6o.fsf@gnu.org> <87r1bxer97.fsf@yahoo.com> <83pmrhien9.fsf@gnu.org> <87mtkmz5ht.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stephen.berman@gmx.net, stefan@marxist.se, 51550@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 27 15:56:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1rQd-0008OZ-Pl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 15:56:47 +0100 Original-Received: from localhost ([::1]:47896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1rQY-0002x4-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 09:56:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1rPu-0002wv-Iz for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 09:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1rPu-00088s-9G for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 09:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1rPu-0003OQ-9j for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 09:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Dec 2021 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51550 X-GNU-PR-Package: emacs Original-Received: via spool by 51550-submit@debbugs.gnu.org id=B51550.164061696013036 (code B ref 51550); Mon, 27 Dec 2021 14:56:02 +0000 Original-Received: (at 51550) by debbugs.gnu.org; 27 Dec 2021 14:56:00 +0000 Original-Received: from localhost ([127.0.0.1]:43785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rPs-0003OC-Iz for submit@debbugs.gnu.org; Mon, 27 Dec 2021 09:56:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rPq-0003O2-2y for 51550@debbugs.gnu.org; Mon, 27 Dec 2021 09:55:58 -0500 Original-Received: from [2001:470:142:3::e] (port=57818 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1rPk-00087Y-K3; Mon, 27 Dec 2021 09:55:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=62r5dkX78gvTeTUE+dVBh+fwS19HHbiMPAUz8lbMWd8=; b=j1pehehCvt4X uLzR1Ig56rUoE1QSEkj4I3rWVbBCpaOXxnnzScdXz/7DT7aEe0QMoJrQK4a2UOxPq/lGFfXlhXcXG AnaJUP+d19lj7a+F/cX9zuTvATWWlBbQ2eYDk7eB/WdzVWnA8i+OrZs3o9ExyO1VqV5PLs9BxmDIN 3odzrgo2vOCuerjdV6Jav4awFe5olNCPXpzYF7R3XKR17WuCeDg8saNixNIs01IsRtPcqD2RZ5gky iTIVVstOLrZk549A5TVpJpoIxvNX5QWJTU85rkmKun1oNz3DQGiGcrk8riymJtZk/LhSpGDipW21W l7SZitI453N5xx1cN/8ZBw==; Original-Received: from [87.69.77.57] (port=2801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1rPk-0002EG-Ib; Mon, 27 Dec 2021 09:55:52 -0500 In-Reply-To: <87mtkmz5ht.fsf@yahoo.com> (message from Po Lu on Mon, 27 Dec 2021 18:50:22 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223191 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , stephen.berman@gmx.net, > 51550@debbugs.gnu.org > Date: Mon, 27 Dec 2021 18:50:22 +0800 > > I think I found the bug, it's in display_line. > > When the label at_end_of_line is reached, it->start_of_box_run_p can be > false. > > Afterwards, set_iterator_to_next is called, which reseats the iterator > to the next line, but doesn't set it->start_of_box_run_p if the face is > now different from the previous face and also has a box. > > I think the solution is to save the face ID of the iterator after the > call to extend_face_to_end_of_line, then compare it to the face after > the iterator is reseated to the next line, and set > it->start_of_box_run_p to true if that face is different and also has a > box. Can you show me a simple Lisp that would reproduce such a problem? I don't think I follow your description. You are actually saying that a screen line cannot begin with text that has a face with the box attribute set?