From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Date: Thu, 13 Jan 2022 12:54:30 +0200 Message-ID: <83sftr3nyx.fsf@gnu.org> References: <509ddd0f-589c-45b0-9b60-5820f4c1d716@www.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ejb@ql.org, 53207@debbugs.gnu.org To: Glenn Morris , Michael Albinus , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 11:56:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7xm1-0009zh-Bz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 11:56:05 +0100 Original-Received: from localhost ([::1]:33358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7xm0-0005HA-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 05:56:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7xl1-0004Qv-Ue for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 05:55:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7xl0-0003nO-Jp for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 05:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7xl0-0006Oa-FV for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 05:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53207 X-GNU-PR-Package: emacs Original-Received: via spool by 53207-submit@debbugs.gnu.org id=B53207.164207129024560 (code B ref 53207); Thu, 13 Jan 2022 10:55:02 +0000 Original-Received: (at 53207) by debbugs.gnu.org; 13 Jan 2022 10:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:60295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xko-0006O3-0r for submit@debbugs.gnu.org; Thu, 13 Jan 2022 05:54:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xkk-0006Nm-O4 for 53207@debbugs.gnu.org; Thu, 13 Jan 2022 05:54:48 -0500 Original-Received: from [2001:470:142:3::e] (port=41426 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7xkb-0003kM-6P; Thu, 13 Jan 2022 05:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EfxWlnYq4VRdDB50tZphwJnQTAQh5+0zoTa1ERFpGgs=; b=h18/+4MWkJpa hfW1ElmcKHqGSc5p3WYnwy5iypwhG7xZebJPYUZBV5vacwFd8RsB02HZaJU9J3c7N7OC/1Olx0M8+ hfDANJuP0aRgbYtoQ9ehfy99ODgw54G2qeemUpv899ZdAi30RQ9/0/1J43b5wjQ7RqxvUy/NxiEDo zn5/zzCAwElb4sK2v7SuYMbG4G0X4Ev8ClCdpR7ofvuswNbJiEtE7VIizrA6IzAE94xIpTjSj3+Ks LBrmQpHfMbPqYKILFWP1LYY4Sdry9OGvSaysV/qPvbgHC8pHn4I8CQCWOa95lcIbvDCSDtLCJuurQ Ab+O4KqWkxJgOB6B+uygOA==; Original-Received: from [87.69.77.57] (port=3680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7xkY-00023F-6y; Thu, 13 Jan 2022 05:54:34 -0500 In-Reply-To: (message from Glenn Morris on Wed, 12 Jan 2022 13:13:40 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224093 Archived-At: > From: Glenn Morris > Date: Wed, 12 Jan 2022 13:13:40 -0500 > Cc: michael.albinus@gmx.de, 53207@debbugs.gnu.org > > Probably a consequence of 9ce6541ac9, specifically: > > * src/filelock.c (lock_file): Don't check create_lockfiles. Actually, the more relevant part is this: (Flock_file): Check create_lockfiles. which did - CHECK_STRING (file); - lock_file (file); +#ifndef MSDOS + /* Don't do locking if the user has opted out. */ + if (create_lockfiles) + { + CHECK_STRING (file); + lock_file (file); + } +#endif /* MSDOS */ > which would seem to mean that ask-user-about-supersession-threat > is no longer called when create-lockfiles is nil. > Was this intentional? Michael, can you please chime in? The long discussion we had back then doesn't seem to mention this aspect, or maybe I'm missing something? We should either document this change (if we think what we have now is the intended behavior), or we should move the call to userlock--ask-user-about-supersession-threat into Flock_file if it's unintended. Personally, I prefer the former, since lock_file accesses the lock file, which doesn't make a lot of sense if the user opted out of the feature. But that's me. Lars, WDYT? Thanks.