unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 54450@debbugs.gnu.org
Subject: bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue
Date: Fri, 18 Mar 2022 19:01:06 +0200	[thread overview]
Message-ID: <83sfrffb59.fsf@gnu.org> (raw)
In-Reply-To: <87pmmjw9ru.fsf@aol.com> (bug-gnu-emacs@gnu.org)

> Date: Fri, 18 Mar 2022 16:38:45 +0100
> From:  Ergus via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> emacs -Q
> (setq highlight-nonselected-windows t)
> 
> C-x 2
> C-x o
> C-x C-f /tmp/test
> (insert some text)
> C-a C-SPC C-f C-f C-f
> C-x o 
> 
> [at this point we should see a region highlighted over the 3 first
> letters of the inserted text in the other winfow buffer (test)]
> 
> then eval this several times:
> 
> (with-selected-window (get-buffer-window "test" 0)
>     (right-char))
> 
> This will move the point in the test window, but the region won't be
> updated.

Thanks.  Does the patch below solve the problem?

diff --git a/src/intervals.c b/src/intervals.c
index 687b237..cbcc100 100644
--- a/src/intervals.c
+++ b/src/intervals.c
@@ -44,6 +44,7 @@
 #include "lisp.h"
 #include "intervals.h"
 #include "buffer.h"
+#include "window.h"
 #include "puresize.h"
 #include "keymap.h"
 
@@ -1885,6 +1886,11 @@ set_point_both (ptrdiff_t charpos, ptrdiff_t bytepos)
       return;
     }
 
+  if (highlight_nonselected_windows
+      && !NILP (Vtransient_mark_mode)
+      && !NILP (BVAR (current_buffer, mark_active)))
+    bset_redisplay (current_buffer);
+
   /* Set TO to the interval containing the char after CHARPOS,
      and TOPREV to the interval containing the char before CHARPOS.
      Either one may be null.  They may be equal.  */





  reply	other threads:[~2022-03-18 17:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pmmjw9ru.fsf.ref@aol.com>
2022-03-18 15:38 ` bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 17:01   ` Eli Zaretskii [this message]
2022-03-18 17:42     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 18:38       ` Eli Zaretskii
2022-03-18 18:52         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 19:46           ` Eli Zaretskii
2022-03-18 18:54         ` Eli Zaretskii
2022-03-18 21:25           ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-19  7:22             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfrffb59.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54450@debbugs.gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).