From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56025: 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin Date: Fri, 24 Jun 2022 09:07:43 +0300 Message-ID: <83sfnud26o.fsf@gnu.org> References: <8e21db9c-0100-998e-f280-81304e7ff61a@cornell.edu> <87mtecl82o.fsf@athena.silentflame.com> <40d9e52f-2041-b341-ff77-546ca7792791@cornell.edu> <87k09elrf8.fsf@athena.silentflame.com> <1de33903-4c55-e043-3754-726f7044f2d0@cornell.edu> <7e7daa2f-dbbc-cd0a-4958-2a2932b17837@gmail.com> <8974408d-91cd-aebd-7a5b-596a57bd640e@cornell.edu> <17d41105-b006-f9ad-af0b-ece84a7f5248@gmail.com> <040b3a36-459b-a94d-f879-7f45aac50bda@cornell.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32179"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, larsi@gnus.org, 56025@debbugs.gnu.org, spwhitton@email.arizona.edu To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 24 08:08:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4cUL-0008BQ-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 08:08:18 +0200 Original-Received: from localhost ([::1]:53090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4cUK-0007ej-J1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jun 2022 02:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4cU6-0007dj-V0 for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 02:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4cU6-0006mE-GQ for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 02:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4cU6-0006AB-AW for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2022 02:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2022 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56025 X-GNU-PR-Package: emacs Original-Received: via spool by 56025-submit@debbugs.gnu.org id=B56025.165605088123684 (code B ref 56025); Fri, 24 Jun 2022 06:08:02 +0000 Original-Received: (at 56025) by debbugs.gnu.org; 24 Jun 2022 06:08:01 +0000 Original-Received: from localhost ([127.0.0.1]:40602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4cU5-00069w-C2 for submit@debbugs.gnu.org; Fri, 24 Jun 2022 02:08:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4cU2-00069g-GC for 56025@debbugs.gnu.org; Fri, 24 Jun 2022 02:07:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4cTv-0006lD-9U; Fri, 24 Jun 2022 02:07:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7JgWOOHkXGsbLgnj2eglfl0hc9EyiEJPJNsIaYYT/Fo=; b=mlYnp1n8V8JK les738IPsWKfgSATKrIwL9ZZYGoaAW2R8CyhSLJ7mMZuPs0C/UgW2QuSYt7HCYLo1a0/LvSSELUdM LJwYpTVXuT4kfae3+lwYXTnhjS7SZ6+oCKWqkxTPkirHuanIBG2m53lBPPYqhU5p3GYtujW+vRMHA 9kHm8gzXNo68R+e5e5f42wjNCMuZMq5aOQM/7/BJHWVKMmKJm2bSXhEQINwBofEbNuxJOQs6V15bx biOBV3wEdK/sAz+ZiaRkqbMyEn7Zc2sasfsZco/aWfM9nBr3/CjTMj69h0edlJmCdDhAV4IBYQGT8 cb2Gb+HW8Po326DGt3SfvQ==; Original-Received: from [87.69.77.57] (port=3718 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4cTu-0001ci-O8; Fri, 24 Jun 2022 02:07:51 -0400 In-Reply-To: <040b3a36-459b-a94d-f879-7f45aac50bda@cornell.edu> (message from Ken Brown on Thu, 23 Jun 2022 21:18:24 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235153 Archived-At: > Date: Thu, 23 Jun 2022 21:18:24 -0400 > From: Ken Brown > > 2. On Cygwin and some other platforms, including Solaris 11.4 I think, it > actually takes a third C-d, for reasons explained in the email thread starting > at https://cygwin.com/pipermail/cygwin/2022-June/251672.html. We're probably > going to change this on Cygwin, but that still leaves other platforms. > > The following patch resolves both issues: > > diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el > index 3644c1a18b..1c4131cb07 100644 > --- a/lisp/eshell/esh-io.el > +++ b/lisp/eshell/esh-io.el > @@ -276,8 +276,8 @@ eshell-close-target > ;; If we're redirecting to a process (via a pipe, or process > ;; redirection), send it EOF so that it knows we're finished. > ((eshell-processp target) > - (if (eq (process-status target) 'run) > - (process-send-eof target))) > + (while (eq (process-status target) 'run) > + (process-send-eof target))) Please add there comments explaining why this is done, or at least point to relevant messages in this bug's discussion (NOT just to the bug number, as the discussion is long and it will be hard to understand what part of it is relevant). Such "tricky" code should always have comments explaining it. Thanks.