From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Wed, 03 Aug 2022 05:28:37 +0300 Message-ID: <83sfme5acq.fsf@gnu.org> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27602"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56896@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 03 04:29:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJ48G-00073F-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Aug 2022 04:29:12 +0200 Original-Received: from localhost ([::1]:44264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJ48F-00064p-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 22:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ486-00062T-5u for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJ485-0007Y9-Tc for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJ485-0004Fu-Pv for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 02:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165949373216343 (code B ref 56896); Wed, 03 Aug 2022 02:29:01 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 02:28:52 +0000 Original-Received: from localhost ([127.0.0.1]:45605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ47w-0004FX-7d for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:28:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ47t-0004FI-JE for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 22:28:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ47o-0007We-6p; Tue, 02 Aug 2022 22:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kJmH8vHLlKp7ArSh/kbSsNQO/SfrJq8BHqVM/hr3fcY=; b=cAzesA3fo0kz 8sUqAedgzqFKUG2wvKKZQ/FHIDY3ewJ3+79zspC2UmePXKy+vapbeFrVSx6Ubguu6K1JNMHFWrPEr 2rHcXPWDB2snhCYUcd3w/g+/r76mnXH5Leh8hCMM6fc5Ts4DJJy2VO4zScN9Rc4AyIQqFqaGEfva5 L38t2OWpDIawl/Za3xqKY/vshpDpXIu05AhHHGlVYBwEQYE1F0H3r/m28nH0nc871K7uRC+eDqed6 n2EmHfrFG+cfxTgzLN07ow9CUe0tTTKbuRA1cxSDNyNBDiUPYeX7cBR5fL2e8YyaZpQ/x5xXRf9D1 NsVuQdACimCU3LBxayEC9A==; Original-Received: from [87.69.77.57] (port=4540 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ47n-0003TZ-Mj; Tue, 02 Aug 2022 22:28:44 -0400 In-Reply-To: <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> (message from Jim Porter on Tue, 2 Aug 2022 13:05:40 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238606 Archived-At: > Cc: 56896@debbugs.gnu.org > From: Jim Porter > Date: Tue, 2 Aug 2022 13:05:40 -0700 > > On 8/2/2022 12:18 PM, Eli Zaretskii wrote: > > Why not make the icon customizable, and offer several possible bitmaps > > to chose from? Hardcoding a single icon will always annoy someone. > > Sure, we could make this customizable. What would be a good way to go > about this? I see three options: > > 1) The status quo: users can already call (define-fringe-bitmap > 'bookmark-fringe-bitmap ...) to make the icon whatever they like, though > that obviously requires writing (or copy/pasting) Elisp. > > 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for > the mark (it currently takes a boolean). This would solve this immediate > case, but not other similar cases. For example, what if a user wants to > customize the fringe icons in diff-mode? > > 3) Provide a generic way to select what any fringe bitmap looks like. > I'm not quite sure how this would be implemented, but it would then > allow users to change the appearance of, say, the `left-curly-arrow' > icon. (In the past, I've done this via (1) by just calling > `define-fringe-bitmap' again.) What I had in mind was 2). Not sure if we need a general capability as in 3), but if it can be implemented cleanly and will be convenient for user options, I don't see why not. Thanks.