From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61880: Native compilation fails to generate trampolines on certain scenarios Date: Wed, 01 Mar 2023 14:26:57 +0200 Message-ID: <83sfeofyi6.fsf@gnu.org> References: <877cw1l455.fsf@sergiodj.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23163"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61880@debbugs.gnu.org To: Sergio Durigan Junior , Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 01 13:27:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXLYB-0005nV-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Mar 2023 13:27:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXLY3-0007cB-Rd; Wed, 01 Mar 2023 07:27:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXLXz-0007Qy-4c for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 07:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXLXy-0007u0-FE for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 07:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXLXx-00062d-Rk for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2023 07:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Mar 2023 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61880 X-GNU-PR-Package: emacs Original-Received: via spool by 61880-submit@debbugs.gnu.org id=B61880.167767361523210 (code B ref 61880); Wed, 01 Mar 2023 12:27:01 +0000 Original-Received: (at 61880) by debbugs.gnu.org; 1 Mar 2023 12:26:55 +0000 Original-Received: from localhost ([127.0.0.1]:52931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXLXq-00062F-Tm for submit@debbugs.gnu.org; Wed, 01 Mar 2023 07:26:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXLXo-00061z-6Y for 61880@debbugs.gnu.org; Wed, 01 Mar 2023 07:26:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXLXh-0007sy-Ef; Wed, 01 Mar 2023 07:26:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fVhL4f6LrE6ybuiaP4amUIhW0plDXT1e2K+i1VJ6fCU=; b=OEPufBrMpHnf JiXUrwW7jrffFCKWO7vq68MKQ/4Sb0VK/JfEz7jUxNBam2zT/1eHjq9wYS5Qhh/MiScgb3EWVc/OX WpJntaOXrAPQqb1fwXAdYCUGfWjkinxKlogA8/QEMxYPj9p8Y+q8P1e7+hHJVQLM1PPhCnjBxZDfj cLNNU1P1H0Be0WVuFln3H4tZTiPVQ/KAURUVmkbxAIlXzqkMmTJbCI61JpwVhN6W2ZaT8hlFCZMkP k76bu8pPgy2I98zOZ1CotmUNC0oicpMRknX8xMangpzVwkTbdNyV3OaLsmrEkN3f30/4LrxrNZtV9 dMf8nXBx40Y+ZpX4pnOyUw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXLXg-0006hG-Hp; Wed, 01 Mar 2023 07:26:45 -0500 In-Reply-To: <877cw1l455.fsf@sergiodj.net> (message from Sergio Durigan Junior on Tue, 28 Feb 2023 19:13:58 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257055 Archived-At: > From: Sergio Durigan Junior > Date: Tue, 28 Feb 2023 19:13:58 -0500 > > While investigating a few bugs affecting Debian's and Ubuntu's Emacs > packages (for example, > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028725), I stumbled > upon a problem that's affecting native compilation on Emacs 28.1+, > currently reproducible with git master as well. > > I haven't been able to fully understand why the problem is happening, > but when there are two primitive functions (that would become > trampolines) being used sequentially, Emacs doesn't generate the > corresponding .eln file for the second function. > > I spent some time investigating the problem and came up with a "minimal" > reproducer: > > --8<---------------cut here---------------start------------->8--- > (require 'cl-lib) > > (defmacro foo--flet (funcs &rest body) > "Like `cl-flet' but with dynamic function scope." > (declare (indent 1)) > (let* ((names (mapcar #'car funcs)) > (lambdas (mapcar #'cdr funcs)) > (gensyms (cl-loop for name in names > collect (make-symbol (symbol-name name))))) > `(let ,(cl-loop for name in names > for gensym in gensyms > collect `(,gensym (symbol-function ',name))) > (unwind-protect > (progn > ,@(cl-loop for name in names > for lambda in lambdas > for body = `(lambda ,@lambda) > collect `(setf (symbol-function ',name) ,body)) > ,@body) > ,@(cl-loop for name in names > for gensym in gensyms > collect `(setf (symbol-function ',name) ,gensym)))))) > > (defun bar (file) > (and (file-exists-p file) (file-readable-p file))) > > (defun test () > (foo--flet ((file-exists-p (file) t) > (file-readable-p (file) nil)) > (message "%s" (bar "/home/sergio/.lesshst")))) > --8<---------------cut here---------------end--------------->8--- > > When I run it using the following Emacs: > > --8<---------------cut here---------------start------------->8--- > GNU Emacs 30.0.50 > Development version 68cc286c0495 on master branch; build date 2023-02-28. > --8<---------------cut here---------------end--------------->8--- > > here is the output I see: > > --8<---------------cut here---------------start------------->8--- > $ emacs -batch -Q -l t.el -f test -L . > Error: native-lisp-load-failed ("file does not exists" "/home/sergio/.emacs.d/eln-cache/30.0.50-23de7b18/subr--trampoline-66696c652d7265616461626c652d70_file_readable_p_0.eln") > debug-early-backtrace() > debug-early(error (native-lisp-load-failed "file does not exists" "/home/sergio/.emacs.d/eln-cache/30.0.50-23de7b18/subr--trampoline-66696c652d7265616461626c652d70_file_readable_p_0.eln")) > native-elisp-load("/home/sergio/.emacs.d/eln-cache/30.0.50-23de7b18/subr--trampoline-66696c652d7265616461626c652d70_file_readable_p_0.eln") > comp-trampoline-search(file-readable-p) > comp-subr-trampoline-install(file-readable-p) > fset(file-readable-p (lambda (file) nil)) > (progn (fset 'file-exists-p #'(lambda (file) t)) (fset 'file-readable-p #'(lambda (file) nil)) (message "%s" (bar "/home/sergio/.lesshst"))) > (unwind-protect (progn (fset 'file-exists-p #'(lambda (file) t)) (fset 'file-readable-p #'(lambda (file) nil)) (message "%s" (bar "/home/sergio/.lesshst"))) (fset 'file-exists-p file-exist > s-p) (fset 'file-readable-p file-readable-p)) > (let ((file-exists-p (symbol-function 'file-exists-p)) (file-readable-p (symbol-function 'file-readable-p))) (unwind-protect (progn (fset 'file-exists-p #'(lambda (file) t)) (fset 'file-re > adable-p #'(lambda (file) nil)) (message "%s" (bar "/home/sergio/.lesshst"))) (fset 'file-exists-p file-exists-p) (fset 'file-readable-p file-readable-p))) > test() > command-line-1(("-l" "t.el" "-f" "test" "-L" ".")) > command-line() > normal-top-level() > Native elisp load failed: "file does not exists", "/home/sergio/.emacs.d/eln-cache/30.0.50-23de7b18/subr--trampoline-66696c652d7265616461626c652d70_file_readable_p_0.eln" > --8<---------------cut here---------------end--------------->8--- > > Do note that this is already affecting a few packages, like buttercup > (see https://github.com/jorgenschaefer/emacs-buttercup/issues/230) and > emacs-web-server, for example. > > Please let me know if you need more information regarding the problem. Thanks. Andrea, can you please look into this? I guess if this happens in Emacs 28 and on master, it also affects Emacs 29, so I hope this can be fixed quickly and safely. TIA.