From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63089: [PATCH] Display offscreen matched openparen Date: Mon, 01 May 2023 16:17:44 +0300 Message-ID: <83sfcgnqbr.fsf@gnu.org> References: <834jp0seoq.fsf@gnu.org> <83sfcjosmj.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63089@debbugs.gnu.org To: Shynur Xie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 15:18:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptTQ7-0002C6-98 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 15:18:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptTPo-0000Rj-KQ; Mon, 01 May 2023 09:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTPm-0000Pu-DO for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptTPl-0003mV-S4 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptTPl-0000si-NZ for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63089 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63089-submit@debbugs.gnu.org id=B63089.16829470313328 (code B ref 63089); Mon, 01 May 2023 13:18:01 +0000 Original-Received: (at 63089) by debbugs.gnu.org; 1 May 2023 13:17:11 +0000 Original-Received: from localhost ([127.0.0.1]:39171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTOx-0000rc-B2 for submit@debbugs.gnu.org; Mon, 01 May 2023 09:17:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTOu-0000rN-2v for 63089@debbugs.gnu.org; Mon, 01 May 2023 09:17:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTOo-0003aK-CM; Mon, 01 May 2023 09:17:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UiS8cLeXHMe5lYtC/QEXd78Ko7Fa6uEcW7bOmwKeKEo=; b=Uhlq2OxnTUAv q40t/mtMToRMCrmJk5SXkeYdyfEyqkuSQiIV66ANEoW+2imYLXYUQLU75kJ0MwFcwLalsc1wDgqHs qeGSQOVSyu6ynxFiloq4khEYun+uQYbtnRFkhPGVgwqUFkl6EBlwg6PzIFXHGqR4SR5/jXS7BqAx4 +s45U97YS010tlKjxFdf1SrS59f67KuTIBFZzmL5BIsTQWCtFS3EL/gaH8UBEDPPfS1TH4VWtk5Iv LAiw9KlSltw95NHaaHJfJ8CKxT0AMY8a2nHPFcl7hitzetnYO4hNjQFRzRolPmUVJTF2DFFxAlfMU U3o5C2zBo7kvxfY6io4yvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTOn-0005uz-Oo; Mon, 01 May 2023 09:17:02 -0400 In-Reply-To: (message from Shynur Xie on Sun, 30 Apr 2023 10:09:18 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260864 Archived-At: > From: Shynur Xie > CC: "63089@debbugs.gnu.org" <63089@debbugs.gnu.org> > Date: Sun, 30 Apr 2023 10:09:18 +0000 > > > I think the default value should be the default face. > > Its default value is nil now. I struggled with whether `nil' (it can > be seen as an empty anonymous face) was better or `default'. > > > "face will be propertized" is incorrect: we propertize text with a > > face, we don't propertize the face. > > Have replaced > "the openparen's face will be propertized by this option" > with > "the openparen will be propertized with a face based on the value of > this option". > > > This should be "30.1". Emacs doesn't have NN.0 versions. > > Got it. > > >> + "Return the line string that contains the openparen at POS. > >> +Remove the line string's properties but give the openparen a face." > > > > This should include the name of the face, > > The name of the face has been added: > "...... give the openparen a face based on the option > `show-paren-openparen-face-in-message'." Thanks. Did you try "make bootstrap" with these changes? The fact that the new option is in paren.el but the code is in simple.el worries me a bit: simple.el is preloaded before paren.el, so this variable might not be known. I think we should move the option to simple,el, and rename it to blink-paren-SOMETHING. Also, it is unusual to have a defcustom that names a face without a corresponding defface that can be used to customize the face. So I think we should add a defface for the face used when the user option is non-nil. > Propertize the matched openparen displayed in the echo area in order to make > it prominent; use light font for non-context characters (i.e., 'Matches'). > * lisp/simple.el (blink-matching-open): Set face shadow for 'Matches'. > * lisp/simple.el (blink-paren-open-paren-line-string): Propertize the macthed ^^^^^^^ Typo there. Also, the lines in the log message are too long, please make them at most 70 column long. Thanks.