From: Eli Zaretskii <eliz@gnu.org>
To: Shynur Xie <one.last.kiss@outlook.com>
Cc: 63089@debbugs.gnu.org
Subject: bug#63089: [PATCH] Display offscreen matched openparen
Date: Mon, 01 May 2023 16:17:44 +0300 [thread overview]
Message-ID: <83sfcgnqbr.fsf@gnu.org> (raw)
In-Reply-To: <SA0PR04MB74338EB5467AAD7AFABCA6C0D7699@SA0PR04MB7433.namprd04.prod.outlook.com> (message from Shynur Xie on Sun, 30 Apr 2023 10:09:18 +0000)
> From: Shynur Xie <one.last.kiss@outlook.com>
> CC: "63089@debbugs.gnu.org" <63089@debbugs.gnu.org>
> Date: Sun, 30 Apr 2023 10:09:18 +0000
>
> > I think the default value should be the default face.
>
> Its default value is nil now. I struggled with whether `nil' (it can
> be seen as an empty anonymous face) was better or `default'.
>
> > "face will be propertized" is incorrect: we propertize text with a
> > face, we don't propertize the face.
>
> Have replaced
> "the openparen's face will be propertized by this option"
> with
> "the openparen will be propertized with a face based on the value of
> this option".
>
> > This should be "30.1". Emacs doesn't have NN.0 versions.
>
> Got it.
>
> >> + "Return the line string that contains the openparen at POS.
> >> +Remove the line string's properties but give the openparen a face."
> >
> > This should include the name of the face,
>
> The name of the face has been added:
> "...... give the openparen a face based on the option
> `show-paren-openparen-face-in-message'."
Thanks. Did you try "make bootstrap" with these changes? The fact
that the new option is in paren.el but the code is in simple.el
worries me a bit: simple.el is preloaded before paren.el, so this
variable might not be known. I think we should move the option to
simple,el, and rename it to blink-paren-SOMETHING.
Also, it is unusual to have a defcustom that names a face without a
corresponding defface that can be used to customize the face. So I
think we should add a defface for the face used when the user option
is non-nil.
> Propertize the matched openparen displayed in the echo area in order to make
> it prominent; use light font for non-context characters (i.e., 'Matches').
> * lisp/simple.el (blink-matching-open): Set face shadow for 'Matches'.
> * lisp/simple.el (blink-paren-open-paren-line-string): Propertize the macthed
^^^^^^^
Typo there.
Also, the lines in the log message are too long, please make them at
most 70 column long.
Thanks.
next prev parent reply other threads:[~2023-05-01 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:39 bug#63089: [PATCH] Display offscreen matched openparen Shynur Xie
2023-04-28 6:28 ` Eli Zaretskii
2023-04-28 12:36 ` Shynur Xie
2023-04-29 11:05 ` Eli Zaretskii
2023-04-30 10:09 ` Shynur Xie
2023-05-01 13:17 ` Eli Zaretskii [this message]
2023-05-01 17:52 ` Shynur Xie
2023-05-02 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfcgnqbr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63089@debbugs.gnu.org \
--cc=one.last.kiss@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).