From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63807: bug in compose-gstring-for-terminal? Date: Wed, 31 May 2023 17:30:25 +0300 Message-ID: <83sfbcefpa.fsf@gnu.org> References: <83a5xkfyc8.fsf@gnu.org> <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63807@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 31 16:30:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4MqD-00041E-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 May 2023 16:30:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4Mpw-0001m0-C3; Wed, 31 May 2023 10:30:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Mpv-0001lp-59 for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 10:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4Mpu-00043e-Rd for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 10:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4Mpu-0002Eq-Nf for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63807 X-GNU-PR-Package: emacs Original-Received: via spool by 63807-submit@debbugs.gnu.org id=B63807.16855433918563 (code B ref 63807); Wed, 31 May 2023 14:30:02 +0000 Original-Received: (at 63807) by debbugs.gnu.org; 31 May 2023 14:29:51 +0000 Original-Received: from localhost ([127.0.0.1]:36139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4Mpi-0002E2-Na for submit@debbugs.gnu.org; Wed, 31 May 2023 10:29:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4Mpg-0002Dn-UW for 63807@debbugs.gnu.org; Wed, 31 May 2023 10:29:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Mpb-0003zg-Ej; Wed, 31 May 2023 10:29:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SeAFvTsOpAy3jKRxj54+hyF2bCL0t0jMephlOif1a2g=; b=phZnr3xcb1LwcsqkR0n/ jMhR9gDAn9eBbDNtpGR2uIMIg+Xj14rf0FHu5OMUbil/XpFS+wHe02H5wTQaDdX78IBySQlMRKF83 6I2qtZX/pe8cTgCRmWmZe45jmtvQiT8qjNH9MC2S1rF9iBS+UFSBlArA1kwWW6hzGjdEeCEnh0QgL t7NBAnjURaLgjQiZC1OS7AOqNyPVe30fWRfuHdGKsnjZOKxcdufYWpC6cxWW7FkhUzszSI8ti/oA8 zIZRqgDzzFeyAA2q98MGpfLiMFhbQsh5pvX4B0KE1wqWXf7ov35du0beh4b1lHcpnoJILZ9h0n3m6 HDLpbvV3KloAWA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4MpZ-0000Hq-Dc; Wed, 31 May 2023 10:29:43 -0400 In-Reply-To: <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 31 May 2023 15:49:23 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262668 Archived-At: > From: Mattias Engdegård > Date: Wed, 31 May 2023 15:49:23 +0200 > Cc: 63807@debbugs.gnu.org > > 31 maj 2023 kl. 15.02 skrev Eli Zaretskii : > > > Setting i to 2 is correct there > > Would you explain why to someone who doesn't know how this is supposed to work? We basically concoct a glyph-string "by hand": > ;; Compose by prepending a space. > (setq gstring (lgstring-insert-glyph gstring i > (lglyph-copy glyph)) > nglyphs (lgstring-glyph-len gstring)) > (setq glyph (lgstring-glyph gstring i)) > (lglyph-set-char glyph 32) > (lglyph-set-width glyph 1) > The main question is whether changing the last assignment to (setq i (+ i 2)) would have unintended consequences. As far as I've been able to determine, testing and inspection say no, it should be completely safe. If we agree that replacing (+ 2) with (+ i 2) is "completely safe", then we basically agree that this code runs only when i == zero, right? Or did I misunderstand what you were saying?