From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64019: 29.0.91; Fix some tree-sitter :match regexps Date: Tue, 13 Jun 2023 05:36:24 +0300 Message-ID: <83sfaww0k7.fsf@gnu.org> References: <87352w4syg.fsf@epfl.ch> <835y7sy9m3.fsf@gnu.org> <877cs8whvy.fsf@epfl.ch> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 64019@debbugs.gnu.org To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 13 04:37:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8tuX-0008md-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jun 2023 04:37:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8tu4-00053p-8G; Mon, 12 Jun 2023 22:37:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8tu2-00053Q-RZ for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 22:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8tu2-0002C1-Iy for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 22:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q8tu2-0000wX-Ep for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 22:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64019-submit@debbugs.gnu.org id=B64019.16866237763564 (code B ref 64019); Tue, 13 Jun 2023 02:37:02 +0000 Original-Received: (at 64019) by debbugs.gnu.org; 13 Jun 2023 02:36:16 +0000 Original-Received: from localhost ([127.0.0.1]:41039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8ttH-0000vQ-Pi for submit@debbugs.gnu.org; Mon, 12 Jun 2023 22:36:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8ttF-0000vE-Lu for 64019@debbugs.gnu.org; Mon, 12 Jun 2023 22:36:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8tt9-00021n-Lw; Mon, 12 Jun 2023 22:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2Qw6M6dXlzBCIJgsfVPBq9i1pNaQAU6JFAh6P67P4F0=; b=fxd6BgWRFW0k P3ckdYfV+gB3TcwiHdlj2iIXpGcYsRy0+KIylHs/de+8OifX5qnxS/59C5fVZ4POKmEMXe7evYr8W V3v6yJKtT2+7egZ3Z5OrxNQRaytFsS/U168TunK9/9USLGQ3AD9vJ0tgrloPzWI2tG9eHiPZQbsvQ CE/h21kZMoGpKj3dP375eQwRmoJtvbrBfjhCA2mg4IOkcxf1VIHDO8joirl6sB0rgxVfkrfJ6cv6K 98XmJlwcULKfH2RzXHMLvUsTsz1N1wiRDIiXpsCsamyFoACMLWdwDr9WxpPJsiY8kY4N2mpEHXYYH RUDmXX1tS3XVHjqnaW+mqQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8tt9-0004Kf-5L; Mon, 12 Jun 2023 22:36:07 -0400 In-Reply-To: <877cs8whvy.fsf@epfl.ch> (message from Basil Contovounesios on Mon, 12 Jun 2023 21:22:09 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263303 Archived-At: > From: Basil Contovounesios > Cc: mattias.engdegard@gmail.com, 64019@debbugs.gnu.org > Date: Mon, 12 Jun 2023 21:22:09 +0100 > > Eli Zaretskii [2023-06-12 11:37 -0400] wrote: > > >> > If this one is wrong, then so is the regexp in cc-mode.el from this one was copied, right? > >> > >> Right, but I was going to suggest fixing that on master rather than > >> emacs-29, since it's been with us longer. > > > > I'd rather we fixed all non-trivial stuff like this on master. We do > > want the pretest end at some point this year, don't we? > > Yes please! Are you referring to the whole patch, or is the rest of it > trivial enough for emacs-29? The changes from "^..$" to "\\`..\\'" are fine. The rest should be discussed on a cased by case basis. And those which should also be fixed in CC Mode should be fixed on master in both.