From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Date: Thu, 06 Jul 2023 10:10:07 +0300 Message-ID: <83sfa1ikhc.fsf@gnu.org> References: <87pm5q4mwc.fsf@yahoo.com> <83352m73g3.fsf@gnu.org> <83wmzx3qoj.fsf@gnu.org> <83leg2u7e6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 64186-done@debbugs.gnu.org To: Wang Diancheng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 06 09:11:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHJ9J-0006Zc-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jul 2023 09:11:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHJ8r-0006lJ-OX; Thu, 06 Jul 2023 03:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHJ8p-0006ib-DD for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 03:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHJ8p-000476-3X for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 03:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHJ8o-0003gg-KT for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 03:11:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2023 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64186 X-GNU-PR-Package: emacs Mail-Followup-To: 64186@debbugs.gnu.org, eliz@gnu.org, dianchengwang@gmail.com Original-Received: via spool by 64186-done@debbugs.gnu.org id=D64186.168862741914107 (code D ref 64186); Thu, 06 Jul 2023 07:11:02 +0000 Original-Received: (at 64186-done) by debbugs.gnu.org; 6 Jul 2023 07:10:19 +0000 Original-Received: from localhost ([127.0.0.1]:39424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHJ86-0003fS-Jg for submit@debbugs.gnu.org; Thu, 06 Jul 2023 03:10:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHJ84-0003fF-Tb for 64186-done@debbugs.gnu.org; Thu, 06 Jul 2023 03:10:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHJ7y-0003lf-NB; Thu, 06 Jul 2023 03:10:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FW6/o3Qt9XmTojTj4vqwFK0WxpRlHDBHpTRTM/eCMns=; b=JMufgMCs6PeSxZwAkbLb 0GE+vEvlHAfGyJXu17YfHWNxnq8tB+I5XReqvJsKjQ4nw8HOttWihOTu/908wf1mQx9CglcaEfrjn H6OEbilwAS51TLH/uyzq64jI6T1An9FqYbLcLPvvJGObv201OTULyILl2ylQL6EhUnwhsSX3bnZty qMwUXTTL/iM7+ZJ3La7PdyUkMLoa+zcG2iKpXeXIQAa1Wh+xDJplfwvTnuImYrcLYyTzfcwMfDZzv iKnFzxWf+WqUQ8b58J5pfF78mtpj+O3diYgCmsrMuYapy6VVgV89JPeJo5GLsPrjT80R2Al4gIqX9 xq4ZEHzPASQ/Mg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHJ7v-0004yK-LL; Thu, 06 Jul 2023 03:10:09 -0400 In-Reply-To: (message from Wang Diancheng on Fri, 30 Jun 2023 15:08:18 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264655 Archived-At: > From: Wang Diancheng > Date: Fri, 30 Jun 2023 15:08:18 +0800 > Cc: luangruo@yahoo.com, 64186@debbugs.gnu.org > > Thanks for your comments.I think what exactly the value of > `gdb-last-command’ is not essential for us. > We just need to know whether `gdb-last-command' is a CLI command in > the background or a MI command, > since here we have already got its "running" status. We must check > the target "async" feature after stopping > the debuggee at the first time in function `gdb-stopped' if > `gdb-last-command' is not a background CLI command or a MI command. > > > > + ;; Set `gdb-non-stop` when `gdb-last-command` is a CLI background > > > + ;; `run` command e.g. r& or MI command `-exec-run` > > > + (when (or (string-match "&\s*$" gdb-last-command) > > > + (string-match "-exec-run" gdb-last-command)) > > > + (gdb-try-check-target-async-support)) > > > > And I'm not sure I understand the idea behind this part: > > > > > @@ -2722,6 +2744,9 @@ gdb-stopped > > > > > > ;; Print "(gdb)" to GUD console > > > (when gdb-first-done-or-error > > > + ;; If run target with CLI foreground command `run`, `target > > > + ;; async` can only be checked when target is stopped > > > + (gdb-try-check-target-async-support) > > > (setq gdb-filter-output (concat gdb-filter-output gdb-prompt-name))) > > > > Can you elaborate? > > Thanks for your questions, according to my comments above, If the > debuggee has been started by > a non-background CLI command e.g. “run" or "attach" (no trailing "&") > commands, we can only > check the target "async" feature at the code stack. > > > > > Finally, please don't quote symbols `like this` in comments. Our > > conventions are to quote symbols 'like this' or `like this'. > > I updated the patch, see the attachment. Thanks, installed on the master branch, and closing the bug. Note that, with this patch you have exhausted the amount of changes we can accept from you without copyright assignment to the FSF. Would you like to start the copyright assignment paperwork at this time, so that we could accept more changes from you in the future? If you are willing to start the assignment process, I will send you the form to fill and the instructions to go with it.