From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Fri, 07 Jul 2023 15:41:35 +0300 Message-ID: <83sf9zgagw.fsf@gnu.org> References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> <83h6qghpdc.fsf@gnu.org> <26cee506f77e9c87e325@heytings.org> <83v8ewf2b4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 14:42:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHkmx-0008tr-Iq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 14:42:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHkmj-00024u-Gt; Fri, 07 Jul 2023 08:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHkmg-00024U-SY for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 08:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHkmg-0006It-JF for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 08:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHkmg-0003J6-0S; Fri, 07 Jul 2023 08:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 07 Jul 2023 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, bugs@gnus.org Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168873370912693 (code B ref 64391); Fri, 07 Jul 2023 12:42:01 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 7 Jul 2023 12:41:49 +0000 Original-Received: from localhost ([127.0.0.1]:42721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHkmQ-0003Id-Pf for submit@debbugs.gnu.org; Fri, 07 Jul 2023 08:41:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHkmM-0003IN-8S for 64391@debbugs.gnu.org; Fri, 07 Jul 2023 08:41:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHkmE-0005GW-RS; Fri, 07 Jul 2023 08:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=avtOpQYlmEYSYd7xv/7w/6Y4mxgp9CYbN+MjGjKFbQ8=; b=oaXW0XAYUODm UeuIQ+kRgRd/BZ/K9B9ii80tOhsS2RqmfWexPL0RVWuRJI6XYTLJMQd7s3JTO0bZ8CJKjA8++QFAe wqnxx8ZB0eZpuPFDh43/Dv8fUgwWoZIb75n+YcQOKM9ugZwFv6vo21eH+xIh+GHwY0yRmLQovgXRD xamK2XCcVzCg6hzWyVmlMnHrlAmUr/MfmwxTNp2P3aOVRMONCjCV9bpwCoMpiUk0UhuY4YwV5Bs8o 0xA5rCu6D321M6bMs/NuqlzkPOPwUfzRXgVTkM/xy+J495bLbehpGakiZVGeF/tVErjss1/5mjbi3 znoTuO7Ux61yDWioWvz5ZQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHkmD-0006UJ-WA; Fri, 07 Jul 2023 08:41:34 -0400 In-Reply-To: (message from Gregory Heytings on Fri, 07 Jul 2023 10:31:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264720 Archived-At: > Date: Fri, 07 Jul 2023 10:31:01 +0000 > From: Gregory Heytings > cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, > monnier@iro.umontreal.ca, bugs@gnus.org > > > >>> I have one question about the new `with-restriction` macro: if it is > >>> intended as a convenience macro for unlabelled narrowing as well, > >>> shouldn't it then expand to the obvious > >>> > >>> (save-restriction > >>> (narrow-to-region BEG END) > >>> BODY) > >>> > >>> instead the much more expensive call to a helper function? > >> > >> Yes. In fact now that we have a separate function for the labeled > >> case, we can remove the funcall in both cases. Patch attached. > > > > You are killing me. > > > > ??? That wasn't meant for the release branch. Then what is?