From: Eli Zaretskii <eliz@gnu.org>
To: Valtteri Vuorikoski <vuori@notcom.org>
Cc: 64577-done@debbugs.gnu.org
Subject: bug#64577: 29.0.92; configure on NetBSD forces unstable terminfo library
Date: Sat, 15 Jul 2023 11:17:13 +0300 [thread overview]
Message-ID: <83sf9pd1x2.fsf@gnu.org> (raw)
In-Reply-To: <6ootbbstpbikcsxwcb2ek6lg3jbyxzgkdd25fwj2vmjpa77oiw@o5uqewt3upum> (message from Valtteri Vuorikoski on Thu, 13 Jul 2023 12:35:51 +0300)
> Date: Thu, 13 Jul 2023 12:35:51 +0300
> From: Valtteri Vuorikoski <vuori@notcom.org>
> Cc: 64577@debbugs.gnu.org
>
> > I don't mind installing the above instead of my proposal, thanks.
>
> Great. I looked at NetBSD 5.1 sources and expanded the check somewhat:
>
> --- a/configure.ac
> +++ b/configure.ac
> @@ -5212,7 +5212,11 @@ AC_DEFUN
> ;;
>
> netbsd)
> - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then
> + # NetBSD versions prior to 6.0 lack native terminfo, but have a
> + # tputs() built on top of termcap in these libraries. Use native
> + # termcap instead in this case. NetBSD >= 6.0 has native terminfo
> + # implementation in -lterminfo.
> + if test "x$LIBS_TERMCAP" = "x-ltermcap" -o "x$LIBS_TERMCAP" = "x-lcurses"; then
> TERMINFO=no
> LIBS_TERMCAP="-ltermcap"
> fi
>
> On 5.1 and older (no ncurses installed), configure's scan through
> tputs_libraries matches either -ltermcap or -lcurses (both seem to
> include tputs() in 5.1, but situation may differ in older versions),
> but this will be termcap under the hood. Therefore force TERMINFO=no
> and also force -ltermcap (as before) to avoid pulling in curses
> unnecessarily.
>
> On 6.0 and newer (again no ncurses) the order of tputs_libraries
> should always cause -lterminfo to match first, so the branch will not
> be taken and TERMINFO stays enabled.
>
> Installing ncurses should now enable full terminfo support on any
> version.
>
> Tested on 9.3 with and without ncurses installed and the result is
> full functionality with TERM=xterm-256color.
Thanks, installed on the emacs-29 branch, and closing the bug.
prev parent reply other threads:[~2023-07-15 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 20:37 bug#64577: 29.0.92; configure on NetBSD forces unstable terminfo library vuori
2023-07-12 12:11 ` Eli Zaretskii
2023-07-12 12:57 ` Valtteri Vuorikoski
2023-07-12 13:32 ` Eli Zaretskii
2023-07-12 14:06 ` Valtteri Vuorikoski
2023-07-12 16:06 ` Eli Zaretskii
2023-07-12 20:22 ` Valtteri Vuorikoski
2023-07-13 5:19 ` Eli Zaretskii
2023-07-13 9:35 ` Valtteri Vuorikoski
2023-07-15 8:17 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sf9pd1x2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64577-done@debbugs.gnu.org \
--cc=vuori@notcom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).