From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Thu, 03 Aug 2023 21:30:33 +0300 Message-ID: <83sf90vv06.fsf@gnu.org> References: <874jruy7xx.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> <83bkfwjkh8.fsf@gnu.org> <871qgsc9fv.fsf@ledu-giraud.fr> <83y1izj2q6.fsf@gnu.org> <87leezhwq0.fsf@ledu-giraud.fr> <87edko9ixu.fsf@ledu-giraud.fr> <87h6piu1zj.fsf@ledu-giraud.fr> <83wmydzn4z.fsf@gnu.org> <87sf91jpe4.fsf@ledu-giraud.fr> <83a5v9z4ve.fsf@gnu.org> <87o7jojs98.fsf@ledu-giraud.fr> <833510xsnt.fsf@gnu.org> <87jzucjchb.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 20:31:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRd6b-0008hk-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 20:31:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRd6G-0006Ih-GY; Thu, 03 Aug 2023 14:31:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd6E-00069Z-S5 for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:31:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRd6E-0008Tv-Hg for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRd6E-0005Yw-Co for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169108743321329 (code B ref 61394); Thu, 03 Aug 2023 18:31:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 3 Aug 2023 18:30:33 +0000 Original-Received: from localhost ([127.0.0.1]:52921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRd5k-0005Xw-Ru for submit@debbugs.gnu.org; Thu, 03 Aug 2023 14:30:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRd5i-0005Xi-3l for 61394@debbugs.gnu.org; Thu, 03 Aug 2023 14:30:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd5c-0008Lk-5A; Thu, 03 Aug 2023 14:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i6VNvehQLvr5hp+6q0SQvRzQREN2ZZXUwElQ+nrG86w=; b=jjXGFFMRI8xg yi04K7dd01/285eBQ6ltL6303Ep4OykvA0d4QZlH2xBTkOD6l9LEc0HACRBU4aES9FmaUBgPnpLIS Fk8Xt5e5LVzqcG4HqB2StxfNap0RhCTLdai5cGE0xBm3GGXztS6ETyZ+KLjtL3f2Z0Wy0v9xez1/1 8U5wOcw3hFqN5GaKERNguerOU4sCawxGBfKBzvCstPIKwjOr0WoNOJtFGQRNmVlrWbMFt4bxQc0V+ B3kciYtrghuXMP37RO2T6KSXb9t6acgzdxooxtwGasPOGMMgCsrg394wOvnNSslhHIyF6UR0C9adA 30aL/FE1ZvR1ywpfEtQLGw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd5a-0002IJ-P0; Thu, 03 Aug 2023 14:30:23 -0400 In-Reply-To: <87jzucjchb.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 03 Aug 2023 18:51:28 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266617 Archived-At: > From: Manuel Giraud > Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org > Date: Thu, 03 Aug 2023 18:51:28 +0200 > > Eli Zaretskii writes: > > >> +(defun image-dired-update-thumbnail-at-point () > >> + "Update the thumbnail at point if the original image file has been > >> +modified. Take care of uncaching and removing the old thumbnail > >> +file." > > > > The first line of the doc string should be a single complete sentence. > > (Just move the "modified" part to the first line, I think there's > > enough space there.) > > I don't understand. "Update the thumbnail at point." does not seem > sufficient because the fact that the original image might be modified is > the main point of this function. What I had in mind is this: (defun image-dired-update-thumbnail-at-point () "Update the thumbnail at point if the original image file has been modified. This function uncaches and removes the thumbnail file under the old name." OK? > What about: > > "When 'image-dired-thumb-naming' is set to 'sha1-contents', 'thumb' and > 'old-thumb' could be different file names. Update the thumbnail then." Much better, thanks.