From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Sun, 06 Aug 2023 07:49:58 +0300 Message-ID: <83sf8wrczt.fsf@gnu.org> References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> <83leerwesd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12846"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 65017@debbugs.gnu.org, monnier@iro.umontreal.ca, eric.marsden@risk-engineering.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 06 06:50:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSVif-000399-0j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Aug 2023 06:50:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSViO-0000Mr-9g; Sun, 06 Aug 2023 00:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSViM-0000Mj-Ij for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 00:50:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSViM-0007Kt-9V for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 00:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSViM-0002Dc-4f for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2023 00:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Aug 2023 04:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.16912973998513 (code B ref 65017); Sun, 06 Aug 2023 04:50:02 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 6 Aug 2023 04:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:58492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSViI-0002DF-Rh for submit@debbugs.gnu.org; Sun, 06 Aug 2023 00:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSViF-0002D1-6D for 65017@debbugs.gnu.org; Sun, 06 Aug 2023 00:49:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSVi7-0007J6-HP; Sun, 06 Aug 2023 00:49:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qBQ7nkWgX4eN3hIkt0yTC0K4TY1B+xZbb577NlQ8GkY=; b=S5IOU1h8IxWj cjTRj456ZPx9X3mRFuvzE5z1jY2sWRcPEK4AC0dWwQlOk/JEtH+f3OkOlY8WYlJowVKOmEPCHSBfz UXNhqAqODimcG1dsWGLBYbZHe+jWx+KiwOwQHLyV6zA1NqmWuwq0Yk9KA2AjhwM0WVeXfBcLctiEY l/H4tulUSxMuLII2OT6eg6yNktV2NU4pLT2ICt1N3+sxVf8YHcqEJ2k/yBUcO7Y+aJ7l88zRHkYHu yF9f1ghOkLASLh15cdMGuj45KmFem0kZyNUv6yZJe2iGEQoJToJ8ffcafKX9uyrHnyVbfH12EicAq qVZE25G7NhduxX1SSRt1hg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSVi2-0003HD-SR; Sun, 06 Aug 2023 00:49:45 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 5 Aug 2023 20:22:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266832 Archived-At: > Date: Sat, 5 Aug 2023 20:22:32 +0000 > Cc: monnier@iro.umontreal.ca, mattias.engdegard@gmail.com, > 65017@debbugs.gnu.org, eric.marsden@risk-engineering.org > From: Alan Mackenzie > > > Thanks, but when you have a solution in hand, please also check its > > effect on performance. AFAIR, this part was tuned for optimal > > performance, back when symbols with positions were introduced; it > > would be a pity to lose performance due to fixing this bug, if that > > can be avoided. > > This should really be in bug #65051, but: > > I've run > > time src/emacs -Q -batch --eval '(let ((a 1) (b 1) (times 10000000)) (while (> times 0) (equal a b) (setq times (1- times))))' > > with different values for a and b (and slightly different quoting > syntax, sometimes). I get the following results, reporting the "user: > time" from GNU/Linux: > > New code: > a, b = 1, 1: 1.760s 1.760s 1,746s > a, b = 1, 3: 1.796s 1,772s 1.777s > 1.0, 1.0: 1,757s 1.776s 1.751s > 1.0, 1.1: 1.792s 1.760s 1.779s > '(a b c), '(a b c): 2.041s 2.042s 2.039s > '(a b c), '(a b d): 2.096s 2.071s 2.084s > "1", "1": 1.841s 1.860s 1.845s > "1", "3": 1.865s 1.846s 1.869s > > Old code: > a, b = 1, 1: 1.744s 1.757s 1.762s > a, b = 1, 3: 1.755s 1,777s 1.759s > 1.0, 1.0: 1.787s 1.748s 1.775s > 1.0, 1.1: 1.762s 1.770s 1.774s > '(a b c), '(a b c): 2.021s 2.057s 2.019s > '(a b c), '(a b d): 2.046s 2.090s 2.100s > "1", "1": 1.854s 1.900s 1.884s > "1", "3": 1.849s 1.833s 1.838s > > I think it's fair to say that the new code is not slower than the old > code, to within the measuring limits of these simple tests. Any > differences, such as they are, are in the second and third decimal > places, and vary more between different measurements, than between the > Old code and New code. They are surely too small to matter. Thanks, this LGTM.