From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63513: [PATCH] Make persist-defvar work with records and hash tables Date: Fri, 08 Sep 2023 15:46:14 +0300 Message-ID: <83sf7ox27d.fsf@gnu.org> References: <871qvz4kdw.fsf@localhost> <87wn1axgh6.fsf@breatheoutbreathe.in> <83jzx925lv.fsf@gnu.org> <87a5xubwoo.fsf@breatheoutbreathe.in> <87v8csku60.fsf@breatheoutbreathe.in> <83cyyz94c6.fsf@gnu.org> <87a5u2ydzg.fsf@breatheoutbreathe.in> <83msy25g0s.fsf@gnu.org> <624CBB7F-1442-400D-8D4D-1B26EBE9DACB@breatheoutbreathe.in> <877cp5bmig.fsf@breatheoutbreathe.in> <8734zoaolv.fsf@localhost> <83zg1wx4eq.fsf@gnu.org> <87wmx098ep.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam@alphapapa.net, phillip.lord@russet.org.uk, 63513-done@debbugs.gnu.org, monnier@iro.umontreal.ca, joseph@breatheoutbreathe.in To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 08 14:48:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeau2-0001Uv-Li for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Sep 2023 14:48:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeat6-0004jy-Bq; Fri, 08 Sep 2023 08:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeat1-0004bg-UE for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 08:47:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeat1-0006b9-JY for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 08:46:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeat3-0003tF-PW for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 08:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63513 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63513-done@debbugs.gnu.org id=D63513.169417719814924 (code D ref 63513); Fri, 08 Sep 2023 12:47:01 +0000 Original-Received: (at 63513-done) by debbugs.gnu.org; 8 Sep 2023 12:46:38 +0000 Original-Received: from localhost ([127.0.0.1]:42538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeasf-0003sd-Lz for submit@debbugs.gnu.org; Fri, 08 Sep 2023 08:46:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qease-0003sR-6I for 63513-done@debbugs.gnu.org; Fri, 08 Sep 2023 08:46:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeasS-0006Qv-Jb; Fri, 08 Sep 2023 08:46:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=js/rDTzQbABt9fHmTEt1x2HGX3VfELXA+dorm8uvt0Y=; b=NCxTbSYxkPLg aeOq2jkg6uNRW6h/BO9JlwXt1p4XxImda0Iwrhj2cZH/hg1zuDxJUEA0kBe08Z9qNU5dU18MQmedK ly96bquUTTOqm+ZsDdhiJAhcUjqGWQ9l5gDQHa/dLkt8doPyXrRWMWLBXA8gngwLdRfXs9OtIWZK9 YRlhRDxE6CntmX+859DboKoc3636NH1YGBRQH3sYU9xIhRVkOmVxJtutLenbFYRS+NBzcZ8BfAqbA LsbvqtQusUgvF8SIvrOQqz3Ikj9Qjy0I+BLf6E6srIvK3JZpD3+HIxXEfKBs9zeEkn9/U0ANzq5rj pXoRQxktI94ZW4DomKlvLA==; In-Reply-To: <87wmx098ep.fsf@localhost> (message from Ihor Radchenko on Fri, 08 Sep 2023 12:06:06 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269772 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, joseph@breatheoutbreathe.in, > adam@alphapapa.net, phillip.lord@russet.org.uk, 63513-done@debbugs.gnu.org > Date: Fri, 08 Sep 2023 12:06:06 +0000 > > Eli Zaretskii writes: > > >> May it be possible to promote `persist-hash-equal' and > >> `persist-copy-tree' to common subr.el functions? > > > > Why do we need them in subr.el, i.e. preloaded? Why cannot these > > functions be autoloaded instead? > > Similar functions - `string-equal-ignore-case' and `copy-tree' - are > already in subr.el. I do not see why the new functions discussed here > should be any different. We make the decision whether a function must be preloaded in a case by case basis, to avoid making the memory footprint of an Emacs session larger than it needs to be. So arguments "by similarity" are not useful in this case; you need to explain why you think these functions are needed right from the startup. Valid reasons include, among others: . function is used by the startup code or during dumping . function is used by all or many important configurations immediately after startup