From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 65491@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#65491: [PATCH] Improve performance allocating vectors
Date: Sat, 16 Sep 2023 19:54:02 +0300 [thread overview]
Message-ID: <83sf7egitx.fsf@gnu.org> (raw)
In-Reply-To: <B8175B38-691A-459A-B454-9AFE2ED7E254@gmail.com> (message from Mattias Engdegård on Sat, 16 Sep 2023 18:32:31 +0200)
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Sat, 16 Sep 2023 18:32:31 +0200
> Cc: 65491@debbugs.gnu.org,
> monnier@iro.umontreal.ca
>
> The new XUNTAG is:
>
> #define XUNTAG(a, type, ctype) ((ctype *) \
> ((uintptr_t) XLP (a) - LISP_WORD_TAG (type)))
>
> so you get a warning from what, conversion of a 64-bit number to (ctype *)?
Yes, I think so:
In file included from dispnew.c:27:
lisp.h: In function 'PSEUDOVECTORP':
lisp.h:813:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
813 | #define XUNTAG(a, type, ctype) ((ctype *) \
| ^
lisp.h:374:6: note: in expansion of macro 'XUNTAG'
374 | ((XUNTAG ((a), Lisp_Vectorlike, union vectorlike_header)->size \
| ^~~~~~
lisp.h:1127:10: note: in expansion of macro 'lisp_h_PSEUDOVECTORP'
1127 | return lisp_h_PSEUDOVECTORP (a, code);
| ^~~~~~~~~~~~~~~~~~~~
lisp.h: In function 'XSYMBOL_WITH_POS':
lisp.h:813:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
813 | #define XUNTAG(a, type, ctype) ((ctype *) \
| ^
lisp.h:1152:12: note: in expansion of macro 'XUNTAG'
1152 | return XUNTAG (a, Lisp_Vectorlike, struct Lisp_Symbol_With_Pos);
| ^~~~~~
lisp.h: In function 'XBARE_SYMBOL':
lisp.h:813:33: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
813 | #define XUNTAG(a, type, ctype) ((ctype *) \
| ^
lisp.h:1159:27: note: in expansion of macro 'XUNTAG'
1159 | intptr_t i = (intptr_t) XUNTAG (a, Lisp_Symbol, struct Lisp_Symbol);
| ^~~~~~
> Does changing the definition to
>
> #define XUNTAG(a, type, ctype) \
> ((ctype *) ((uintptr_t) XLP (a) - (uintptr_t)LISP_WORD_TAG (type)))
>
> help? (That is, cast the LISP_WORD_TAG return value to uintptr_t.)
It does, but LISP_WORD_TAG(type) is a 64=bit type with the only bits
set above 32 bit, so how casting it to uintptr_t is TRT?
Why did you need to change the original cast in the first place?
next prev parent reply other threads:[~2023-09-16 16:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 9:59 bug#65491: [PATCH] Improve performance allocating vectors Ihor Radchenko
2023-08-26 7:14 ` Eli Zaretskii
2023-08-26 7:27 ` Ihor Radchenko
2023-08-26 7:31 ` Eli Zaretskii
2023-08-26 7:51 ` Ihor Radchenko
2023-08-26 8:07 ` Ihor Radchenko
2023-08-26 9:01 ` Eli Zaretskii
2023-08-26 7:47 ` Ihor Radchenko
2023-08-26 12:01 ` Mattias Engdegård
2023-08-26 14:54 ` Ihor Radchenko
2023-08-26 14:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 9:54 ` Mattias Engdegård
2023-09-16 14:58 ` Mattias Engdegård
2023-09-16 16:12 ` Eli Zaretskii
2023-09-16 16:17 ` Eli Zaretskii
2023-09-16 16:32 ` Mattias Engdegård
2023-09-16 16:54 ` Eli Zaretskii [this message]
2023-09-16 17:03 ` Mattias Engdegård
2023-09-16 17:11 ` Eli Zaretskii
2023-09-17 3:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-17 17:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 2:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 2:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 3:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-18 4:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 16:54 ` Mattias Engdegård
2023-09-16 17:09 ` Eli Zaretskii
2023-09-16 17:22 ` Mattias Engdegård
2023-09-16 18:19 ` Eli Zaretskii
2023-09-16 19:04 ` Mattias Engdegård
2023-09-16 19:46 ` Paul Eggert
2023-09-17 5:18 ` Eli Zaretskii
2023-09-17 15:22 ` Paul Eggert
2023-09-17 16:15 ` Eli Zaretskii
2023-09-17 16:37 ` Paul Eggert
2023-09-17 16:44 ` Eli Zaretskii
2023-09-18 16:10 ` Mattias Engdegård
2023-09-18 17:13 ` Eli Zaretskii
2023-09-19 13:28 ` Mattias Engdegård
2023-09-19 14:04 ` Eli Zaretskii
2023-09-19 14:05 ` Mattias Engdegård
2023-09-25 16:06 ` Mattias Engdegård
2023-08-27 16:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 10:14 ` Ihor Radchenko
2023-08-28 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 12:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sf7egitx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65491@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).