unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#66404: [PATCH] Use delete-all-overlays in clean-mode
@ 2023-10-08  9:58 Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-10-08 10:26 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-08  9:58 UTC (permalink / raw)
  To: 66404

[-- Attachment #1: Type: text/plain, Size: 78 bytes --]

Tags: patch

Is there a reason to use dolist instead of delete-all-overlays?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-delete-all-overlays-in-clean-mode.patch --]
[-- Type: text/patch, Size: 902 bytes --]

From d47e0cbe9ecaeb0cd4da12ab70f03d4c138f9265 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Sun, 8 Oct 2023 02:54:10 -0700
Subject: [PATCH] Use delete-all-overlays in clean-mode

* lisp/simple.el (clean-mode): Replace dolist
---
 lisp/simple.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index b770d9d7d33..8f2bd84d805 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -549,8 +549,7 @@ Other major modes are defined by comparison with this one."
   "A mode that removes all overlays and text properties."
   (kill-all-local-variables t)
   (let ((inhibit-read-only t))
-    (dolist (overlay (overlays-in (point-min) (point-max)))
-      (delete-overlay overlay))
+    (delete-all-overlays)
     (set-text-properties (point-min) (point-max) nil)
     (setq-local yank-excluded-properties t)))
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#66404: [PATCH] Use delete-all-overlays in clean-mode
  2023-10-08  9:58 bug#66404: [PATCH] Use delete-all-overlays in clean-mode Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-10-08 10:26 ` Eli Zaretskii
  2023-10-08 10:32   ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-10-08 10:26 UTC (permalink / raw)
  To: Joseph Turner; +Cc: 66404

> Date: Sun, 08 Oct 2023 02:58:45 -0700
> From:  Joseph Turner via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Is there a reason to use dolist instead of delete-all-overlays?

Already asked.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#66404: [PATCH] Use delete-all-overlays in clean-mode
  2023-10-08 10:26 ` Eli Zaretskii
@ 2023-10-08 10:32   ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-10-08 11:40     ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-08 10:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 66404


Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 08 Oct 2023 02:58:45 -0700
>> From:  Joseph Turner via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Is there a reason to use dolist instead of delete-all-overlays?
>
> Already asked.

Oops! Sorry, please close this. (Is there a way for me to close my own issues?)





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#66404: [PATCH] Use delete-all-overlays in clean-mode
  2023-10-08 10:32   ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-10-08 11:40     ` Eli Zaretskii
  2023-10-08 20:54       ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-10-08 11:40 UTC (permalink / raw)
  To: Joseph Turner; +Cc: 66404-done

> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Cc: 66404@debbugs.gnu.org
> Date: Sun, 08 Oct 2023 03:32:40 -0700
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Date: Sun, 08 Oct 2023 02:58:45 -0700
> >> From:  Joseph Turner via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> Is there a reason to use dolist instead of delete-all-overlays?
> >
> > Already asked.
> 
> Oops! Sorry, please close this.

Done.

> (Is there a way for me to close my own issues?)

Yes, see admin/notes/bugtracker.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#66404: [PATCH] Use delete-all-overlays in clean-mode
  2023-10-08 11:40     ` Eli Zaretskii
@ 2023-10-08 20:54       ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 5+ messages in thread
From: Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-08 20:54 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 66404-done, Stefan Kangas


Eli Zaretskii <eliz@gnu.org> writes:

>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>
>> (Is there a way for me to close my own issues?)
>
> Yes, see admin/notes/bugtracker.

Thank you!! I was not aware of this.

Stefan: Please consider mentioning admin/notes/bugtracker in your talk.

Joseph





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-10-08 20:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-08  9:58 bug#66404: [PATCH] Use delete-all-overlays in clean-mode Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 10:26 ` Eli Zaretskii
2023-10-08 10:32   ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 11:40     ` Eli Zaretskii
2023-10-08 20:54       ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).