From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode Date: Sat, 20 Jan 2024 11:05:22 +0200 Message-ID: <83sf2stlwt.fsf@gnu.org> References: <83v88yml4h.fsf@gnu.org> <83o7ehe1fu.fsf@gnu.org> <87mstuvjlu.fsf@thornhill.no> <83r0iqnuqa.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33830"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jacobtophatleeming@gmail.com, 67709@debbugs.gnu.org To: theo@thornhill.no Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 20 10:06:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rR7Ix-0008cd-LC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jan 2024 10:06:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rR7If-0002Km-Jr; Sat, 20 Jan 2024 04:06:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR7Id-0002KI-Ih for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:05:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rR7Id-0001IP-Aa for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:05:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rR7If-0003iW-Oy for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jan 2024 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67709-submit@debbugs.gnu.org id=B67709.170574155414273 (code B ref 67709); Sat, 20 Jan 2024 09:06:01 +0000 Original-Received: (at 67709) by debbugs.gnu.org; 20 Jan 2024 09:05:54 +0000 Original-Received: from localhost ([127.0.0.1]:60806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7IY-0003i9-BR for submit@debbugs.gnu.org; Sat, 20 Jan 2024 04:05:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7IW-0003hu-3q for 67709@debbugs.gnu.org; Sat, 20 Jan 2024 04:05:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR7IN-0001Fp-ON; Sat, 20 Jan 2024 04:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IYObHdTloyOWHgtkqt2BLHzNgCeP34OYw/fXBjN2lic=; b=kgQxlype0uDt v8mxhAeyxAH9yYRdQw80cAm45Kz6gDe1N4aEMvPremnQl30Sy+rIVTH76j//oCe1epph0D1kxxeMl Qeui89W/+l4bx6qbny65XuUQ+97L5JtfOFRBKBGQwrk1H+ejNNLWN63/oLVPIYhnPJ9McI+nAqOXB yimA7669/7vN5f3R2nY3rxtOu7wiyTDCz5lRZ56HWZiNok2V99B55i3sEXqvOJ30HqqHZU7tKwdoJ hus2pTA+VsPqYNZyPoGZfh1iDKLmFtN+93Kvxjtw46zuE6KFsqw07jQmC0v3I6YPJDqXb7+REGxbg wiDIM3kXRhHxx4zPuguNNQ==; In-Reply-To: <83r0iqnuqa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 09 Jan 2024 21:59:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278571 Archived-At: Ping! Ping! Any progress there? > Cc: jacobtophatleeming@gmail.com, 67709@debbugs.gnu.org > Date: Tue, 09 Jan 2024 21:59:41 +0200 > From: Eli Zaretskii > > > From: Theodor Thornhill > > Cc: jacobtophatleeming@gmail.com, 67709@debbugs.gnu.org > > Date: Thu, 28 Dec 2023 09:04:13 +0100 > > > > Eli Zaretskii writes: > > > > > Ping! Theo, could you please look into this? > > > > > > > Absolutely, thanks! > > Any progress? > > > >> Cc: 67709@debbugs.gnu.org > > >> Date: Sat, 16 Dec 2023 13:39:58 +0200 > > >> From: Eli Zaretskii > > >> > > >> > From: Jacob Leeming > > >> > Date: Fri, 8 Dec 2023 13:44:14 +0000 > > >> > > > >> > >From emacs -Q: > > >> > > > >> > Evaluate this elisp to set up treesitter for csharp: > > >> > > > >> > (setq treesit-language-source-alist '((c-sharp > > >> > "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src")) > > >> > treesit-load-name-override-list '((c-sharp > > >> > "libtree-sitter-csharp" "tree_sitter_c_sharp")) > > >> > major-mode-remap-alist '((csharp-mode . csharp-ts-mode))) > > >> > > > >> > Insert the following text into a csharp-ts-mode buffer: > > >> > > > >> > void ExampleFunction( > > >> > int arg1, > > >> > int arg2, > > >> > int arg3, > > >> > int arg4, > > >> > int arg5 > > >> > ) > > >> > { > > >> > Console.WriteLine(arg1); > > >> > } > > >> > > > >> > Try to indent the parameters of the function with > > >> > indent-for-tab-command. Nothing will happen. > > >> > > > >> > This issue can be fixed with the following patch: > > >> > > > >> > > > >> > > > >> > diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el > > >> > index 53c52e6..8cc4e95 100644 > > >> > --- a/lisp/progmodes/csharp-mode.el > > >> > +++ b/lisp/progmodes/csharp-mode.el > > >> > @@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules > > >> > ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset) > > >> > ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset) > > >> > ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset) > > >> > - ((parent-is "parenthesized_expression") parent-bol > > >> > csharp-ts-mode-indent-offset)))) > > >> > + ((parent-is "parenthesized_expression") parent-bol > > >> > csharp-ts-mode-indent-offset) > > >> > + ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset)))) > > >> > > > >> > (defvar csharp-ts-mode--keywords > > >> > '("using" "namespace" "class" "if" "else" "throw" "new" "for" > > >> > > >> Theo, any comments? Should I install this? > > >> > > >> Thanks. > > >> > > >> > > >> > > >> > > > > > >