From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1077: 23.0.60; x-create-frame: (wrong-type-argument number-or-marker-p nil) Date: Tue, 30 Nov 2010 06:05:47 +0200 Message-ID: <83r5e38nhg.fsf@gnu.org> References: <003e01c9257c$a385d800$0200a8c0@us.oracle.com> <009701c9263f$9cce7120$0200a8c0@us.oracle.com> <000001c94cc1$e10e9c40$0200a8c0@us.oracle.com> <8F1F8998D60341099C4204B7BDD8AD4F@us.oracle.com> <96BC00F728B94AC18A15EA95B66C5248@us.oracle.com> <83zksv5g7j.fsf@gnu.org> <0A475933984F4CDA855D91C8B7639E3B@us.oracle.com> <83fwum5xzk.fsf@gnu.org> <9F24875655894485A414CD785D95725B@us.oracle.com> <83ipzh9qze.fsf@gnu.org> <4CF386C9.5070909@gmx.at> <8362vg9ctt.fsf@gnu.org> <4CF409A3.1030906@gmx.at> <83y68b96c5.fsf@gnu.org> <71C125BECEDF4C5E9F703E5743F76893@us.oracle.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1291199424 22041 80.91.229.12 (1 Dec 2010 10:30:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Dec 2010 10:30:24 +0000 (UTC) Cc: 1077@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 01 11:30:19 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PNjx1-0001ZW-Qa for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Dec 2010 11:30:16 +0100 Original-Received: from localhost ([127.0.0.1]:32826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNjx0-0002Su-Ol for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Dec 2010 05:30:14 -0500 Original-Received: from [140.186.70.92] (port=46032 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNfqz-0007hb-S0 for bug-gnu-emacs@gnu.org; Wed, 01 Dec 2010 01:08:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNHcJ-0007CA-HY for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 23:15:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNHcJ-0007C6-G2 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 23:14:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PNHOo-0006ue-Ao; Mon, 29 Nov 2010 23:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2010 04:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 1077-submit@debbugs.gnu.org id=B1077.129108961926521 (code B ref 1077); Tue, 30 Nov 2010 04:01:02 +0000 Original-Received: (at 1077) by debbugs.gnu.org; 30 Nov 2010 04:00:19 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNHO5-0006th-Ud for submit@debbugs.gnu.org; Mon, 29 Nov 2010 23:00:18 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNHO2-0006tS-F8 for 1077@debbugs.gnu.org; Mon, 29 Nov 2010 23:00:15 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LCO00D00J79HJ00@a-mtaout20.012.net.il> for 1077@debbugs.gnu.org; Tue, 30 Nov 2010 06:05:48 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.63.39]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCO00DGNJDN5450@a-mtaout20.012.net.il>; Tue, 30 Nov 2010 06:05:48 +0200 (IST) In-reply-to: <71C125BECEDF4C5E9F703E5743F76893@us.oracle.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 29 Nov 2010 23:01:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42049 Archived-At: > From: "Drew Adams" > Cc: <1077@debbugs.gnu.org> > Date: Mon, 29 Nov 2010 13:33:00 -0800 > > > (define-key menu-bar-showhide-menu [menu-bar-mode] > > `(menu-item ,(purecopy "Menu-bar") toggle-menu-bar-mode-from-frame > > :help ,(purecopy "Turn menu-bar on/off") > > - :button (:toggle . (> (frame-parameter nil 'menu-bar-lines) 0)))) > > + :button (:toggle . (> (frame-parameter (or menu-updating-frame > > + (selected-frame)) > > + 'menu-bar-lines) 0)))) > > Ignore if this makes no sense; I'm not following the details of this, and I'm > ignorant about menu-updating-frame. > > Can menu-updating-frame be nil? It can, but not when we are evaluating menu items as part of creating a frame. I left the reference to selected-frame for that very reason. > In that case, don't we get the same error/bug? I'm not sure. I'm still trying to understand when and why did the menu-bar-lines parameter got a nil value in the minibuffer frame's parameters. Depending on what I find, there could be an additional change. If this happens only in minibuffer frames, then the above should be enough to fix the bug, because minibuffer frames without a menu bar will never evaluate their menu items.