From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11617: Don't use 'register'; these days it's not needed. Date: Sun, 03 Jun 2012 18:09:07 +0300 Message-ID: <83r4twbffw.fsf@gnu.org> References: <4FCAFED3.4080008@cs.ucla.edu> <831ulwcw2v.fsf@gnu.org> <87ipf8tpph.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1338736220 13802 80.91.229.3 (3 Jun 2012 15:10:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2012 15:10:20 +0000 (UTC) Cc: eggert@cs.ucla.edu, 11617@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 17:10:17 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SbCRc-0006Pz-RO for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 17:10:16 +0200 Original-Received: from localhost ([::1]:34836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCRc-000840-Hd for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 11:10:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCRZ-0007wf-2B for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:10:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbCRX-0004Cl-BG for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:10:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbCRX-0004Cg-86 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:10:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SbCTK-00033X-7l for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2012 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11617 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11617-submit@debbugs.gnu.org id=B11617.133873627711691 (code B ref 11617); Sun, 03 Jun 2012 15:12:02 +0000 Original-Received: (at 11617) by debbugs.gnu.org; 3 Jun 2012 15:11:17 +0000 Original-Received: from localhost ([127.0.0.1]:55912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCSa-00032V-JC for submit@debbugs.gnu.org; Sun, 03 Jun 2012 11:11:16 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:46650) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCSX-00032I-Oi for 11617@debbugs.gnu.org; Sun, 03 Jun 2012 11:11:14 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M5100600RD7D400@a-mtaout22.012.net.il> for 11617@debbugs.gnu.org; Sun, 03 Jun 2012 18:09:01 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M510057LRF0WJ80@a-mtaout22.012.net.il>; Sun, 03 Jun 2012 18:09:00 +0300 (IDT) In-reply-to: <87ipf8tpph.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60672 Archived-At: > From: Chong Yidong > Cc: Paul Eggert , 11617@debbugs.gnu.org > Date: Sun, 03 Jun 2012 22:50:02 +0800 > > Eli Zaretskii writes: > > >> Attached is a patch to remove 'register' from the mainline > >> Emacs source code. > > > > FWIW, I see no compelling reason for this change, even after I've read > > the explanations. This keyword is a cue to the compiler, so it in > > general conveys non-trivial information. If today's compilers mostly > > ignore that, it doesn't mean this will always be the state of affairs. > > However, by removing this, we lose those cues forever. > > I wonder how many of those register variables were actually added after > profiling to see if they make any difference. My guess is none, > i.e. those keywords are bogus. ??? I don't necessarily see the connection between profiling and the keyword uses. The way I see it, these are cues to the compiler, they tell which of the variables are accessed in the inner loops and more intensively, under the expected data flow.