From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Date: Thu, 16 May 2013 22:19:48 +0300 Message-ID: <83r4h6spez.fsf@gnu.org> References: <87d2sqzqq5.fsf@engster.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1368732069 21751 80.91.229.3 (16 May 2013 19:21:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 19:21:09 +0000 (UTC) Cc: 14411@debbugs.gnu.org To: David Engster Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 21:21:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ud3jf-0007UG-1P for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 21:21:07 +0200 Original-Received: from localhost ([::1]:52876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3je-0006Cw-IN for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 15:21:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3jW-00064H-Dt for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:21:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud3jP-0007Ds-LE for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:20:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3jP-0007DV-Gh for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:20:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ud3ja-0001cF-BY for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.13687320406168 (code B ref 14411); Thu, 16 May 2013 19:21:02 +0000 Original-Received: (at 14411) by debbugs.gnu.org; 16 May 2013 19:20:40 +0000 Original-Received: from localhost ([127.0.0.1]:47775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3jE-0001bR-B0 for submit@debbugs.gnu.org; Thu, 16 May 2013 15:20:40 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:37969) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3jB-0001bC-Pm for 14411@debbugs.gnu.org; Thu, 16 May 2013 15:20:39 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MMW00E00O9JY500@a-mtaout22.012.net.il> for 14411@debbugs.gnu.org; Thu, 16 May 2013 22:19:49 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMW00EITOD0K1A0@a-mtaout22.012.net.il>; Thu, 16 May 2013 22:19:49 +0300 (IDT) In-reply-to: <87d2sqzqq5.fsf@engster.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74343 Archived-At: > From: David Engster > Date: Thu, 16 May 2013 21:09:38 +0200 > > When doing parallel builds using GNU Make, jumping to the location of a > warning/error from the compilation buffer often does not work. This is > because GNU Make enters different directories at the same time, and the > resulting output is intermixed. The attached patch fixes this by looking > at all directories which were entered up to the point of the > warning/error, instead of just taking the directly preceding one. I'm > aware that this is not a perfect solution, since those directories might > contain files with identical names, in which case Emacs might show the > wrong one, but IMO it's still an improvement over the current > situation. This feature can also be disabled through a new variable. I think this problem should be fixed in GNU Make. And, lo and behold, the next release of GNU Make will have a switch that will prevent the directories from being mixed. Perhaps it would be better to teach compile.el to detect support for that switch (-O or --output-sync) and use it if available when -j is also used, than to kludge around the current behavior.