From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20843: 24.5; Profiler error: "Invalid sampling interval" Date: Mon, 22 Jun 2015 18:35:49 +0300 Message-ID: <83r3p3hi22.fsf@gnu.org> References: <83k2v1l7g4.fsf@gnu.org> <5585B8C4.1050204@cornell.edu> <83r3p6i4b1.fsf@gnu.org> <5585DF69.7090008@cornell.edu> <83oak9hzzs.fsf@gnu.org> <558737F7.4080709@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1434987443 24963 80.91.229.3 (22 Jun 2015 15:37:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Jun 2015 15:37:23 +0000 (UTC) Cc: sva-news@mygooglest.com, 20843@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 22 17:37:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z73mY-0004I3-HI for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jun 2015 17:37:10 +0200 Original-Received: from localhost ([::1]:40782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z73mY-0005La-1B for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jun 2015 11:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z73mT-0005LN-UC for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 11:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z73mQ-000751-Jl for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 11:37:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z73mQ-00074x-GW for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 11:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z73mQ-0004DY-99 for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20843-submit@debbugs.gnu.org id=B20843.143498737416139 (code B ref 20843); Mon, 22 Jun 2015 15:37:02 +0000 Original-Received: (at 20843) by debbugs.gnu.org; 22 Jun 2015 15:36:14 +0000 Original-Received: from localhost ([127.0.0.1]:54640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z73ld-0004CC-Qh for submit@debbugs.gnu.org; Mon, 22 Jun 2015 11:36:14 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:53633) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z73lb-0004Bx-FP for 20843@debbugs.gnu.org; Mon, 22 Jun 2015 11:36:12 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NQC00600R836L00@mtaout29.012.net.il> for 20843@debbugs.gnu.org; Mon, 22 Jun 2015 18:35:33 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQC00331RB87N30@mtaout29.012.net.il>; Mon, 22 Jun 2015 18:35:33 +0300 (IDT) In-reply-to: <558737F7.4080709@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104225 Archived-At: > Date: Sun, 21 Jun 2015 18:17:27 -0400 > From: Ken Brown > CC: sva-news@mygooglest.com, 20843@debbugs.gnu.org > > > If so, we cannot test this at > > configure time, because it means we will have to run a program, which > > is not a good idea. > > > > So in that case, I think we should simply disable the CPU profiler on > > Cygwin using "#ifndef __CYGWIN__" or some such. > > Done as commit 5fac0de. Thanks. > >>> Also, the diagnostics should be improved, as the > >>> wording is misleading in that case. > >> > >> As it stands, profiler-cpu-start reports "Invalid sampling interval" > >> whenever setup_cpu_timer fails to start the timer, regardless of the > >> reason. I'll try to improve this. > > > > Yes, please. > > How's this: Looks fine, but perhaps it would be cleaner to return the actual message string or some distinctive code from setup_cpu_timer. This would avoid the need for a global variable. Thanks.