unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: 21548-done@debbugs.gnu.org
Subject: bug#21548: 25.0.50; [PATCH] Prevent empty -path arguments for not-ignored directories in	rgrep's find commands
Date: Wed, 30 Sep 2015 10:43:30 +0300	[thread overview]
Message-ID: <83r3lgbbdp.fsf@gnu.org> (raw)
In-Reply-To: <5603DE67.1010903@orcon.net.nz>

> Date: Thu, 24 Sep 2015 23:28:39 +1200
> From: Phil Sainty <psainty@orcon.net.nz>
> 
> rgrep's `grep-find-ignored-directories' conditional-ignore behaviour
> (for list elements which are cons cells) produces 'find' constraints
> like: "find . -type d \( -path  -o -path \*/SCCS [...]" (i.e. a -path
> argument with no value) when the associated function returns nil.
> 
> The nil elements need to be deleted from the list before the command
> line arguments for the ignored directories are generated.

Thanks, I pushed this.

Please in the future accompany your patches with a ChangeLog-format
commit message; see CONTRIBUTE for details.

We seem to lack tests for this stuff (and Grep in general).  Would you
like to write some tests for that?  TIA.





      reply	other threads:[~2015-09-30  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 11:28 bug#21548: 25.0.50; [PATCH] Prevent empty -path arguments for not-ignored directories in rgrep's find commands Phil Sainty
2015-09-30  7:43 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r3lgbbdp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21548-done@debbugs.gnu.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).