From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18522: 24.4.50; mapcar is very slow Date: Fri, 26 Feb 2016 10:48:16 +0200 Message-ID: <83r3fzeu27.fsf@gnu.org> References: <8738bkdjqg.fsf@micropit.roche-blanche.homenet.org> <878u2eun9o.fsf@roche-blanche.net> <834md2niqt.fsf@gnu.org> <87k2lyszy2.fsf@roche-blanche.net> <83bn79n66p.fsf@gnu.org> <87vb5hry9y.fsf@roche-blanche.net> <83r3g4lnor.fsf@gnu.org> <87r3g4o4uw.fsf@roche-blanche.net> <83h9h0jwfo.fsf@gnu.org> <87mvqru119.fsf@roche-blanche.net> <8360xfjsyr.fsf@gnu.org> <878u2bs7tl.fsf@roche-blanche.net> <83r3g3iajr.fsf@gnu.org> <87twkypfqx.fsf@roche-blanche.net> <83vb5egg8y.fsf@gnu.org> <87fuwikmzc.fsf@roche-blanche.net> <83io1ege6r.fsf@gnu.org> <87y4a9kh9e.fsf@roche-blanche.net> <87vb5dvf6c.fsf@gnus.org> <8760xdi54j.fsf@roche-blanche.net> <83vb5cg4r6.fsf@gnu.org> <87egc0noyf.fsf@gnus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1456476566 17679 80.91.229.3 (26 Feb 2016 08:49:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Feb 2016 08:49:26 +0000 (UTC) Cc: pmlists@free.fr, 18522@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 26 09:49:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZE5L-0005YT-8O for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Feb 2016 09:49:15 +0100 Original-Received: from localhost ([::1]:48117 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZE5K-000827-L0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Feb 2016 03:49:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZE5D-00081N-Pa for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 03:49:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZE58-0003Ow-LV for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 03:49:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZE58-0003Os-Dg for bug-gnu-emacs@gnu.org; Fri, 26 Feb 2016 03:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aZE57-0001mk-SM; Fri, 26 Feb 2016 03:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 26 Feb 2016 08:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18522 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 18522-submit@debbugs.gnu.org id=B18522.14564765206834 (code B ref 18522); Fri, 26 Feb 2016 08:49:01 +0000 Original-Received: (at 18522) by debbugs.gnu.org; 26 Feb 2016 08:48:40 +0000 Original-Received: from localhost ([127.0.0.1]:46800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZE4j-0001m6-7d for submit@debbugs.gnu.org; Fri, 26 Feb 2016 03:48:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35544) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZE4e-0001lq-RN for 18522@debbugs.gnu.org; Fri, 26 Feb 2016 03:48:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZE4U-0003Aj-Gm for 18522@debbugs.gnu.org; Fri, 26 Feb 2016 03:48:27 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZE4U-0003Af-AR; Fri, 26 Feb 2016 03:48:22 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1986 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aZE4T-0006MP-EX; Fri, 26 Feb 2016 03:48:21 -0500 In-reply-to: <87egc0noyf.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 26 Feb 2016 13:43:44 +1030) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113858 Archived-At: > From: Lars Ingebrigtsen > Cc: Peter Münster , > 18522@debbugs.gnu.org > Date: Fri, 26 Feb 2016 13:43:44 +1030 > > > . parse-time-string should try to avoid binding case-fold-search > > globally, or at all > > It's kinda weird. This starts with: > > (defun parse-time-string (string) > > [...] > > (temp (parse-time-tokenize (downcase string)))) > > which calls > > (defsubst parse-time-string-chars (char) > (save-match-data > (let (case-fold-search str) > (cond ((eq char ?+) 1) > ((eq char ?-) -1) > ((eq char ?:) ?d) > ((string-match "[[:upper:]]" (setq str (string char))) ?A) > ((string-match "[[:lower:]]" str) ?a) > ((string-match "[[:digit:]]" str) ?0))))) > > !? > > Since we've already downcased the entire string, both the > `case-fold-search' and the match to [[:upper:]] seem rather > nonsensical? Yes, weird. And even if someone thought of using parse-time-string-chars in other places that don't necessarily downcase the string, I don't understand why we should test a character by making it a string, then matching against [:upper:]. Maybe I'm missing something.