bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Artur Malabarba]

1. Start emacs -q

2. Create a buffer in fundamental-mode and type some text.

3. Evaluate this:

    (setq x-gtk-use-system-tooltips nil)
    (add-text-properties (point-min) (point-max) '(help-echo "OKOK"))
    (face-remap-add-relative 'tooltip '((:foreground "blue")))

4. Tooltips displayed are NOT blue.

5. If, instead, I add an entry to face-remapping-alist without making it
buffer-local, the tooltip does indeed display blue.

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Date: Fri, 08 Apr 2016 16:22:11 -0300
> 
>     (setq x-gtk-use-system-tooltips nil)
>     (add-text-properties (point-min) (point-max) '(help-echo "OKOK"))
>     (face-remap-add-relative 'tooltip '((:foreground "blue")))
> 
> 4. Tooltips displayed are NOT blue.

Why did you expect them to be blue?  Tooltips are special frames that
don't display any buffer, whereas face-remap-add-relative is
documented as affecting only the buffer that was current at the time
it was called.

More generally, face remapping is designed to allow buffer-local
changes to faces.  If you want to affect the way tooltips are
displayed, you should instead customize the 'tooltip' face or the
parameters in 'tooltip-frame-parameters'.

IOW, I don't see any bug here.

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Artur Malabarba]

Eli Zaretskii <eliz@gnu.org> writes:

> Why did you expect them to be blue?  Tooltips are special frames that
> don't display any buffer, whereas face-remap-add-relative is
> documented as affecting only the buffer that was current at the time
> it was called.

Sorry, to me it wasn't obvious that tooltips are different frames.

> More generally, face remapping is designed to allow buffer-local
> changes to faces.  If you want to affect the way tooltips are
> displayed, you should instead customize the 'tooltip' face or the
> parameters in 'tooltip-frame-parameters'.

I want to change the way tooltips are displayed in a major-mode I'm
writing. I don't want to change this face globally for the user, only
change it in the buffers where this major-mode is active.

I understand that might not be possible, in which case feel free to
close.


Artur

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[martin rudalics]

 > Why did you expect them to be blue?  Tooltips are special frames that
 > don't display any buffer,

A tooltip frame displays a buffer called "*tip*".

 > whereas face-remap-add-relative is
 > documented as affecting only the buffer that was current at the time
 > it was called.

martin

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[martin rudalics]

 > I want to change the way tooltips are displayed in a major-mode I'm
 > writing. I don't want to change this face globally for the user, only
 > change it in the buffers where this major-mode is active.
 >
 > I understand that might not be possible, in which case feel free to
 > close.

Try using ‘x-show-tip’ directly.

martin

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 23246@debbugs.gnu.org
> Date: Fri, 08 Apr 2016 17:06:01 -0300
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Why did you expect them to be blue?  Tooltips are special frames that
> > don't display any buffer, whereas face-remap-add-relative is
> > documented as affecting only the buffer that was current at the time
> > it was called.
> 
> Sorry, to me it wasn't obvious that tooltips are different frames.

I've added to the ELisp manual some documentation about that, which
makes it clear these are frames.

> I want to change the way tooltips are displayed in a major-mode I'm
> writing. I don't want to change this face globally for the user, only
> change it in the buffers where this major-mode is active.
> 
> I understand that might not be possible, in which case feel free to
> close.

I think you can achieve that by putting your own hook function on the
tooltip-functions list.

Let me know if there's anything else to do about this bug report.

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> Date: Sat, 09 Apr 2016 11:04:09 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 23246@debbugs.gnu.org
> 
>  > Why did you expect them to be blue?  Tooltips are special frames that
>  > don't display any buffer,
> 
> A tooltip frame displays a buffer called "*tip*".

Right, I should have been more accurate, and say "any of your own
buffers".

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[martin rudalics]

 > I've added to the ELisp manual some documentation about that, which
 > makes it clear these are frames.

Perfectly done.

Congratulations, martin

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> Date: Sat, 09 Apr 2016 14:50:44 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 23246@debbugs.gnu.org
> 
>  > I've added to the ELisp manual some documentation about that, which
>  > makes it clear these are frames.
> 
> Perfectly done.
> 
> Congratulations, martin

Thanks.

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Sat, Apr 9, 2016 at 6:35 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Artur Malabarba <bruce.connor.am@gmail.com>
> > Cc: 23246@debbugs.gnu.org
> > Date: Fri, 08 Apr 2016 17:06:01 -0300
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > Why did you expect them to be blue?  Tooltips are special frames that
> > > don't display any buffer, whereas face-remap-add-relative is
> > > documented as affecting only the buffer that was current at the time
> > > it was called.
> >
> > Sorry, to me it wasn't obvious that tooltips are different frames.
>
> I've added to the ELisp manual some documentation about that, which
> makes it clear these are frames.
>
> > I want to change the way tooltips are displayed in a major-mode I'm
> > writing. I don't want to change this face globally for the user, only
> > change it in the buffers where this major-mode is active.
> >
> > I understand that might not be possible, in which case feel free to
> > close.
>
> I think you can achieve that by putting your own hook function on the
> tooltip-functions list.
>
> Let me know if there's anything else to do about this bug report.
>

No, I think we can close this. Thanks for the help.
And thanks to martin too. `x-show-tip' just might work.

[-- Attachment #2: Type: text/html, Size: 1878 bytes --]

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Date: Mon, 11 Apr 2016 03:15:20 +0000
> Cc: 23246@debbugs.gnu.org
> 
>  I think you can achieve that by putting your own hook function on the
>  tooltip-functions list.
> 
>  Let me know if there's anything else to do about this bug report.
> 
> No, I think we can close this. Thanks for the help. 

Done.

> And thanks to martin too. `x-show-tip' just might work.

You mean, tooltip-functions doesn't?

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[martin rudalics]

 >> `x-show-tip' just might work.
 >
 > You mean, tooltip-functions doesn't?

The doc-string of ‘x-show-tip’ advises that

   This is an internal function; Lisp code should call ‘tooltip-show’.

but ‘tooltip-show’ overrides any face properties of TEXT via

   (propertize text 'face 'tooltip)

in a hardcoded fashion.  So if you want to display your own face
attributes, you currently have to call ‘x-show-tip’ directly despite of
its advice.

Obviously, GTK+ (and probably OS X) tooltips override such attributes
anyway, so changing this might probably never given high priority.
Still, Emacs tooltip frames provide the possibility so why not use it?

martin

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Drew Adams]

>  >> `x-show-tip' just might work.
>  > You mean, tooltip-functions doesn't?
> 
> The doc-string of ‘x-show-tip’ advises that
>    This is an internal function; Lisp code should call ‘tooltip-show’.

Yes, and that's misguided, at least for the reason you give.

> but ‘tooltip-show’ overrides any face properties of TEXT via
>    (propertize text 'face 'tooltip)
> in a hardcoded fashion.  So if you want to display your own face
> attributes, you currently have to call ‘x-show-tip’ directly despite of
> its advice.

Exactly.  Plus ‘x-show-tip’ works across Emacs versions.
It is preferable, IMO.

> Obviously, GTK+ (and probably OS X) tooltips override such attributes
> anyway, so changing this might probably never given high priority.
> Still, Emacs tooltip frames provide the possibility so why not use it?

Yes.  Just do it.

When Emacs wants to steer users away from X toward Y, especially
because the name X is misleading (e.g. `x-<something'), it had
better make sure that Y is really an adequate replacement for X.

bug#23246: 25.0.92; Local face-remapping-alist doesn't affect tooltips

[Eli Zaretskii]

> Date: Tue, 12 Apr 2016 09:30:17 +0200
> From: martin rudalics <rudalics@gmx.at>
> 
>  >> `x-show-tip' just might work.
>  >
>  > You mean, tooltip-functions doesn't?
> 
> The doc-string of ‘x-show-tip’ advises that
> 
>    This is an internal function; Lisp code should call ‘tooltip-show’.

It doesn't really matter, IMO.

> but ‘tooltip-show’ overrides any face properties of TEXT via
> 
>    (propertize text 'face 'tooltip)
> 
> in a hardcoded fashion.  So if you want to display your own face
> attributes, you currently have to call ‘x-show-tip’ directly despite of
> its advice.

I agree, but I thought that the function which calls x-show-tip should
be put in tooltip-functions, to avoid the need to copycat the
machinery of popping up and popping down tooltips.