From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 23020@debbugs.gnu.org
Subject: bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent
Date: Tue, 26 Apr 2016 09:04:50 +0300 [thread overview]
Message-ID: <83r3ds29dp.fsf@gnu.org> (raw)
In-Reply-To: <m34mapb8pv.fsf@gnus.org> (message from Lars Magne Ingebrigtsen on Tue, 26 Apr 2016 00:54:20 +0200)
> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Cc: 23020@debbugs.gnu.org
> Date: Tue, 26 Apr 2016 00:54:20 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Sending email
> >> Sending email done
> >> smtpmail-send-it: Sending failed: 550 This message scored too many
> >> spam points in response to .
> >>
> >> So it shouldn't say "done" until it's really done.
> >
> > Isn't it message.el that says "done" in this case?
>
> I think it must be this code... I can't find the string "Sending email"
> in message.el.
>
> (defun smtpmail-send-data (process buffer)
> (let ((data-continue t) sending-data
> (pr (with-current-buffer buffer
> (make-progress-reporter "Sending email "
> (point-min) (point-max)))))
> (with-current-buffer buffer
> (goto-char (point-min)))
> (while data-continue
> (with-current-buffer buffer
> (progress-reporter-update pr (point))
> (setq sending-data (buffer-substring (point-at-bol) (point-at-eol)))
> (end-of-line 2)
> (setq data-continue (not (eobp))))
> (smtpmail-send-data-1 process sending-data))
> (progress-reporter-done pr)))
But if this is the code, then it says "done" when it really is done,
no?
next prev parent reply other threads:[~2016-04-26 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 10:24 bug#23020: 25.1.50; smtpmail reports that it's sent the message before it's sent Lars Magne Ingebrigtsen
2016-03-15 17:01 ` Eli Zaretskii
2016-04-25 22:54 ` Lars Magne Ingebrigtsen
2016-04-25 22:59 ` Lars Magne Ingebrigtsen
2016-04-26 6:04 ` Eli Zaretskii [this message]
2016-04-26 9:58 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r3ds29dp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23020@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).