From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25128: Reorder lisp.h to declare types before using them Date: Wed, 07 Dec 2016 18:09:15 +0200 Message-ID: <83r35jiuvo.fsf@gnu.org> References: <04822678-e178-4b23-1a5b-ff452cbd88a3@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481127019 24524 195.159.176.226 (7 Dec 2016 16:10:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Dec 2016 16:10:19 +0000 (UTC) Cc: 25128@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 07 17:10:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEenM-0005db-Ck for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Dec 2016 17:10:12 +0100 Original-Received: from localhost ([::1]:39758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEenQ-0006EU-D4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Dec 2016 11:10:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEenH-0006Az-RP for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 11:10:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEenC-0007oS-5B for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 11:10:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cEenC-0007oO-1l for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 11:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cEenB-0000g2-RI for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 11:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2016 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25128 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25128-submit@debbugs.gnu.org id=B25128.14811269412521 (code B ref 25128); Wed, 07 Dec 2016 16:10:01 +0000 Original-Received: (at 25128) by debbugs.gnu.org; 7 Dec 2016 16:09:01 +0000 Original-Received: from localhost ([127.0.0.1]:59416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEemD-0000ea-Gl for submit@debbugs.gnu.org; Wed, 07 Dec 2016 11:09:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEemC-0000eH-PX for 25128@debbugs.gnu.org; Wed, 07 Dec 2016 11:09:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEem3-0007Lj-OA for 25128@debbugs.gnu.org; Wed, 07 Dec 2016 11:08:55 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEem3-0007Lf-KS; Wed, 07 Dec 2016 11:08:51 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1417 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cEem2-0007W0-Vd; Wed, 07 Dec 2016 11:08:51 -0500 In-reply-to: <04822678-e178-4b23-1a5b-ff452cbd88a3@cs.ucla.edu> (message from Paul Eggert on Tue, 6 Dec 2016 23:19:19 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126609 Archived-At: > From: Paul Eggert > Date: Tue, 6 Dec 2016 23:19:19 -0800 > > Attached is a patch to reorder src/lisp.h so that more types are declared before > use. The main motivation is to eventually add support for > -fcheck-pointer-bounds; future changes will need access to type sizes (e.g., > XCONS might need sizeof (struct Lisp_Cons)), which should be easy after this > change. Also, the change shortens lisp.h a bit and (if you ask me) makes it > easier to read, since the basic functions for a type are now declared next to > the type. > > I would like to install this soon, and am posting this as a bug report to give > Eli and others a heads-up, in case some MS-Windows module now needs to include > process.h. This may be needed because XPROCESS is now defined in process.h > instead of lisp.h; similarly for buffer.h, window.h, termhooks.h. Thanks. I'd appreciate if someone could beat me to it, as I'm busy merging and testing the concurrency branch, hopefully soon to land on master. In any case, could you please wait with pushing this for a few days until concurrency actually lands? I'm in the last stages of testing the merge, and it would minimize the impact of the final merging. The changes in lisp.h due to concurrency are very few, FWIW, so I don't believe it will require you to make changes in your patch due to the merge. TIA