From: Eli Zaretskii <eliz@gnu.org>
To: Itai Berli <itai.berli@gmail.com>
Cc: 27525@debbugs.gnu.org
Subject: bug#27525: 25.1; Line wrapping of bidi paragraphs
Date: Fri, 21 Jul 2017 16:01:35 +0300 [thread overview]
Message-ID: <83r2xa9c5s.fsf@gnu.org> (raw)
In-Reply-To: <CABsNJ=OqYN1ZkHEHK8WUus5ph8_P1KtdVLFKqEpR_8h=mDsC5g@mail.gmail.com> (message from Itai Berli on Fri, 21 Jul 2017 12:44:40 +0300)
> From: Itai Berli <itai.berli@gmail.com>
> Date: Fri, 21 Jul 2017 12:44:40 +0300
>
> 1. The bidi logic is entirely contained in the file bidi.c.
"Bidi logic" is not well defined. If you mean the implementation of
the UBA, then yes, it's in bidi.c, with the sole exception of
mirroring of characters due to bidi context, which is in xdisp.c.
> 2. The display logic is entirely contained in the file xdisp.c.
If by "display logic" you mean the layout parts, i.e. the code which
constructs screen lines out of characters and breaks physical lines
into logical lines, then yes.
> 3. The interface between the two modules is minimal. If I wish to cancel Emacs' bidi features, all I need to do
> is comment out a couple lines in xdisp.c and a user who doesn't use bidi documents will never know the
> difference.
Not exactly. There are numerous code snippets that handle
bidi-related complications, like the fact that buffer position is no
longer monotonously increasing with screen coordinates, all over in
xdisp.c. But if bidi.c functions are never called, these snippets
will most probably be no-ops.
> 4. All the complications you mentioned are limited to code in xdisp.c
No. The current implementation includes a couple of functions in
bidi.c that perform on-the-flight reordering of characters into visual
order. These functions will have to be bypassed, and instead there
should be a new implementation of reordering which works on a laid-out
screen line. In addition, the data structures shared by bidi.c and
xdisp.c will have to be changed to include the resolved level of each
character and some other information (part of that is already there,
but it will have to be revisited to make sure it doesn't hide some of
the info needed for reordering, because currently the information is
stored post-reordering).
next prev parent reply other threads:[~2017-07-21 13:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 7:23 bug#27525: 25.1; Line wrapping of bidi paragraphs Itai Berli
2017-06-29 14:55 ` Eli Zaretskii
2017-06-29 18:35 ` Itai Berli
2017-07-04 9:10 ` Itai Berli
2017-07-04 9:11 ` Itai Berli
2017-07-04 9:19 ` Itai Berli
2017-07-04 14:43 ` Eli Zaretskii
2017-07-04 14:52 ` Itai Berli
2017-07-04 15:19 ` Eli Zaretskii
2017-07-04 23:05 ` Richard Stallman
2017-07-05 2:29 ` Eli Zaretskii
2017-07-05 22:59 ` Richard Stallman
2017-07-06 2:39 ` Eli Zaretskii
2017-07-06 16:01 ` Richard Stallman
2017-07-06 16:17 ` Eli Zaretskii
2017-07-07 18:23 ` Richard Stallman
2017-07-07 19:21 ` Eli Zaretskii
2017-07-09 18:17 ` Benjamin Riefenstahl
2017-07-09 18:30 ` Eli Zaretskii
2017-07-19 8:50 ` Itai Berli
2017-07-19 12:59 ` Itai Berli
2017-07-19 17:28 ` Eli Zaretskii
2017-07-19 21:40 ` Itai Berli
2017-07-20 5:08 ` Eli Zaretskii
2017-07-20 7:01 ` Itai Berli
2017-07-20 11:09 ` Eli Zaretskii
2017-07-21 6:19 ` Itai Berli
2017-07-21 8:37 ` Eli Zaretskii
2017-07-21 9:44 ` Itai Berli
2017-07-21 10:58 ` Itai Berli
2017-07-21 13:19 ` Eli Zaretskii
2017-07-21 13:01 ` Eli Zaretskii [this message]
2017-07-19 17:24 ` Eli Zaretskii
2017-07-04 14:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r2xa9c5s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27525@debbugs.gnu.org \
--cc=itai.berli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).