From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25025: python-shell-calculate-command is wrong Date: Wed, 16 Aug 2017 17:32:10 +0300 Message-ID: <83r2wbfus5.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502894006 30388 195.159.176.226 (16 Aug 2017 14:33:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 14:33:26 +0000 (UTC) Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 16 16:33:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzNf-00076t-EB for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 16:33:11 +0200 Original-Received: from localhost ([::1]:50478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhzNl-00009g-TV for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 10:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhzNa-00006u-F6 for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 10:33:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhzNW-0004xd-IX for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 10:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhzNW-0004xT-Fe for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 10:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhzNW-0000ck-9l for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2017 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 25025-submit@debbugs.gnu.org id=B25025.15028939572366 (code B ref 25025); Wed, 16 Aug 2017 14:33:02 +0000 Original-Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 14:32:37 +0000 Original-Received: from localhost ([127.0.0.1]:41264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzN6-0000c6-VE for submit@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:37 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzN4-0000bt-Ka for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhzMv-0004Xb-Ij for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhzMv-0004XB-Ek; Wed, 16 Aug 2017 10:32:25 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhzMu-0007wz-QM; Wed, 16 Aug 2017 10:32:25 -0400 In-reply-to: <87inhnzs54.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135815 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 25025@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 16 Aug 2017 07:08:55 -0400 > > > Okay, it looks like the consensus is that we should apply the > > `combine-and-quote-strings' fix for now, and possibly in future switch > > to something more shell based. > > > > I've pushed it to master as 8f611e5e2309 "Fix bad quoting of > > python-shell-interpreter", and I'm closing this bug. > > This broke the test python-shell-calculate-command-1 on Windows. We > could update the test to match the new python-shell-calculate-command > implementation, but since the test body is basically just a copy of that > function, it looks pretty useless to me. I think we should just remove > that test. Could you please elaborate about the reason(s) for the breakage of the test? I'm not sure I follow, and so cannot make up my mind whether I agree with removing the test. Thanks.