unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 29523@debbugs.gnu.org, masm-emacs@masm11.ddo.jp
Subject: bug#29523: 25.3; buffer overflow in ns-font-name on mac
Date: Sat, 02 Dec 2017 10:10:09 +0200	[thread overview]
Message-ID: <83r2sd1rfi.fsf@gnu.org> (raw)
In-Reply-To: <20171201194308.GA44478@breton.holly.idiocy.org> (message from Alan Third on Fri, 1 Dec 2017 19:43:08 +0000)

> Date: Fri, 1 Dec 2017 19:43:08 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: 29523@debbugs.gnu.org
> 
> > The bug is in ns_xlfd_to_fontname() in nsterm.m:
> > 
> >   if (!strncmp (xlfd, "--", 2))
> >     sscanf (xlfd, "--%*[^-]-%[^-]179-", name);
> >   else
> >     sscanf (xlfd, "-%*[^-]-%[^-]179-", name);
> > 
> > The positions of "179" are incorrect. They should be:
> > 
> >   if (!strncmp (xlfd, "--", 2))
> >     sscanf (xlfd, "--%*[^-]-%179[^-]-", name);
> >   else
> >     sscanf (xlfd, "-%*[^-]-%179[^-]-", name);
> 
> Thanks for the fix. I expect this is copyright exempt

It is.

Thanks.





  reply	other threads:[~2017-12-02  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 14:53 bug#29523: 25.3; buffer overflow in ns-font-name on mac Yuuki Harano
2017-12-01 19:43 ` Alan Third
2017-12-02  8:10   ` Eli Zaretskii [this message]
2017-12-02 13:50     ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r2sd1rfi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=29523@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=masm-emacs@masm11.ddo.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).